Skip to content

emrg: fix flaky DialogHost rename prefill assertion (waitFor useEffect-filled input)#1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 27, 2026
Merged

emrg: fix flaky DialogHost rename prefill assertion (waitFor useEffect-filled input) #1031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion emrg/gui/renderer/src/components/DialogHost.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -178,7 +178,9 @@ describe("DialogHost (Batch 5 slice 4)", () => {
ref2.current?.openRename();
await waitFor(() => expect(screen.getByTestId("rename-dialog")).toBeInTheDocument());
const input = screen.getByTestId("rename-input") as HTMLInputElement;
expect(input.value).toBe("旧标题");
// RenameDialog fills the input in a useEffect after mount — waitFor (flake
// fix: CI raced the effect and observed '' instead of the prefill).
await waitFor(() => expect(input.value).toBe("旧标题"));
fireEvent.change(input, { target: { value: "新标题" } });
fireEvent.click(screen.getByTestId("rename-ok"));
await waitFor(() => expect(calls2.renameSession.length).toBe(1));
Expand Down
Loading