Skip to content

emrg: renderer shell test — waitFor the Edit form name prefill (fix flaky taskUpdate test)#1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 27, 2026
Merged

emrg: renderer shell test — waitFor the Edit form name prefill (fix flaky taskUpdate test) #1038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion emrg/gui/renderer/src/components/Shell.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -377,8 +377,11 @@ describe("Shell (Batch 5 slice 3 chat wiring)", () => {
await waitFor(() => expect(screen.getByTestId("task-row")).toBeInTheDocument());
fireEvent.click(screen.getByTitle("Edit"));
await waitFor(() => expect(screen.getByTestId("task-form-dialog")).toBeInTheDocument());
// 预填由 TaskFormDialog 的 useEffect 在 mount 后执行（vanilla openTaskForm 语义，
// 见 #1031 同类 flaky 修复）。用 waitFor 等待 effect 填充值，避免在 effect 跑完前
// 读到空 name.value（#1035 轮询测试的 fake-timer/async 交错曾偶发暴露此竞态）。
const name = screen.getByTestId("task-form-name") as HTMLInputElement;
expect(name.value).toBe("evo");
await waitFor(() => expect(name.value).toBe("evo"));
expect(name.disabled).toBe(true);
fireEvent.change(screen.getByTestId("task-form-interval"), { target: { value: "7200" } });
fireEvent.click(screen.getByTestId("task-form-save"));
Expand Down
Loading