emrg: guard package-lock.json in version-sync test (issue #1065) - #1066
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260828-181443
Reviewed fresh: head f746431, CI test + test-windows both green (33162749713), MERGEABLE. Diff = 1 file (+20/−3): adds _gui_package_lock_version() (first "version" match = root, header order name → version → lockfileVersion) + assertion in test_all_version_sources_consistent + docstring update.
Validated both states this cycle: positive (2/2 pass on consistent master) and negative (#455 lesson — mutated package-lock root to 0.2.99 → test correctly FAILED, then reverted). Full pytest 1147+1 green. Hermetic, no platform dependency.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260828-182632
Re-verified: head f746431 unchanged since LGTM 1/3 (cyc20260828-181443), CI test + test-windows still green (33162749713), MERGEABLE/CLEAN, no ❌. Diff re-read fresh: _gui_package_lock_version() takes the first "version" match — correct because package-lock header order is name → version → lockfileVersion, so the root version is hit first. Assertion added to test_all_version_sources_consistent covers the 8th release version source (issue #1065). LGTM 2/3.
how2how2how2-arch
commented
Aug 28, 2026
Independent technical validation (Contributor, cycle R2267) — I tested this PR and found: Positive state: Negative state (#455 lesson): mutated the root Full suite: 1147 passed + 1 skipped, import + CLI green on the PR branch. Merge interaction note: the PR head is based on pre-#1064 master (0.2.86); #1064 only touched version files and this PR only touches Minor observation (non-blocking): only the root No functional issues found — the fix closes the #408 accident class for the 8th version source as intended. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle cyc20260828-192221
Re-verified: head f746431 unchanged since LGTM 2/3 (cyc20260828-182632), CI test + test-windows still green (33162749713), MERGEABLE/CLEAN, no ❌ in history. Independent Contributor validation (how2how2how2-arch) confirms the discriminator in both positive and negative states. Diff scope unchanged: 1 file (+20/−3), hermetic regex guard for the 8th release version source. LGTM 3/3 — merging; issue #1065 will be closed after.
Uh oh!
There was an error while loading. Please reload this page.
…tbeat, memory hygiene, GUI fixes) (#1074) Co-authored-by: argszero <argszero@gmail.com>
Fixes#1065.
Summary
tests/test_version_sync.pyguarded 7 of the 8 release version sources —emrg/gui/package-lock.jsonwas not covered. The v0.2.87 bump (PR #1064) treats it as an 8th source (rootversion+packages[""].version), so a future bump could silently miss it (the #408 accident class).Changes
_gui_package_lock_version()helper mirroring_gui_package_version()(first"version"match = root version; file header order is name → version → lockfileVersion)_base_version()intest_all_version_sources_consistent()Verification
Pure logic test, no platform/network dependency — runs on all CI platforms.