Skip to content

emrg: tighten bare excepts in _send_shutdown and _stop_daemon#16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 2 commits into from
Jul 18, 2026
Merged

emrg: tighten bare excepts in _send_shutdown and _stop_daemon #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5f906d
emrg: tighten bare excepts in _send_shutdown and _stop_daemon
argszero Jul 18, 2026
152634e
merge master
argszero Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions emrg/__main__.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -136,7 +136,7 @@ async def _send_shutdown() -> bool:
if line:
data = json.loads(line.decode().strip())
return data.get("type") == "shutdown_ack"
except Exception:
except (OSError, asyncio.TimeoutError, json.JSONDecodeError, UnicodeDecodeError):
return False
return False

Expand DownExpand Up@@ -173,7 +173,7 @@ async def _get_pid():
print("daemon stopped.")
else:
print("daemon not running (no pid from ping).")
except Exception:
except (OSError, asyncio.TimeoutError, json.JSONDecodeError, UnicodeDecodeError):
print("daemon not running.")


Expand Down