emrg: build-release 二十次修复 — smoke Windows cmd 路径 cygpath 转换(rant #13) - #388
Merged
Conversation
第 20 次实跑:3/4 平台成功(WINDIR 判断修复生效,POSIX 恢复), Windows Inno 编译通过(artifacts 生成),smoke 第 1 步 ✓,第 2 步 daemon 启动 exit 1(5 秒即挂,短于 15 秒轮询)。 根因:cmd //c start 分支的 $HOME 是 Git Bash POSIX 路径 (/c/Users/runneradmin/...),cmd 是 Windows 原生程序不认识 POSIX 路径 → start 失败 → daemon 未启动 → exit 1。 修复:cmd 分支用 cygpath -m 将 $HOME/.emrg/install/bin/emrgd.cmd 转 Windows 路径(C:/Users/... 正斜杠形式,cmd 可读)。2 处同步。 验证: - bash -n OK - cygpath -m 转换模拟:/c/Users/runneradmin/... → C:/Users/runneradmin/... ✓ - POSIX 分支不受影响(无 WINDIR → nohup)✓ - pytest 464 passed;import checks OK
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0091
审查内容:smoke-test.sh cmd 分支 cygpath -m 转 Windows 路径($HOME POSIX→C:/...),2 处同步。修第 20 次 Windows daemon 启动 exit 1。
验证:bash -n OK;cygpath 转换模拟正确;POSIX 分支不受影响;pytest 464 passed。根因分析准确(cmd 不认 POSIX 路径)。
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0092
第二次复核:diff 与上轮一致(smoke-test.sh cmd 分支 cygpath -m 转 Windows 路径,2 处)。bash -n OK;转换模拟正确;POSIX 分支不受影响。无新增问题。
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0093
第三次复核:diff 稳定(smoke-test.sh cmd 分支 cygpath -m 转 Windows 路径)。bash -n OK;转换模拟正确;pytest 464 passed。3 个不同 cycle(0091/0092/0093)连续 LGTM,满足合并条件。
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
第 20 次实跑:3/4 平台成功(WINDIR 判断修复生效,POSIX 恢复),Windows Inno 编译通过(artifacts 生成),smoke 第 1 步 ✓,第 2 步 daemon 启动 exit 1(5 秒即挂,短于 15 秒轮询)。
根因:
cmd //c start分支的$HOME是 Git Bash POSIX 路径(/c/Users/runneradmin/...),cmd 是 Windows 原生程序不认识 POSIX 路径 → start 失败 → daemon 未启动 → exit 1。修复:cmd 分支用
cygpath -m将$HOME/.emrg/install/bin/emrgd.cmd转 Windows 路径(C:/Users/... 正斜杠形式,cmd 可读)。2 处同步。验证:
背景:rant #13 Phase 4 发布期。合并后重打 tag 第 21 次实跑,预期 4/4 全绿 → Release 发布。