emrg: make-installer Linux 注释/echo 反映 R116 AppImage 收集(rant #13 收尾) - #392
Merged
Conversation
R116(PR #391)后 Linux 分支同时产出 tar.gz + AppImage,但注释与 echo 仍停留在"AppImage built by electron-builder in CI"的旧描述——日志与 文档与实际行为不一致。修正为反映收集动作(collected R116),方便 CI 排障时快速确认 AppImage 已被脚本收集到 artifacts。
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0103
纯文档/日志修正(+4/-2):Linux 分支注释 + echo 反映 R116 收集行为,与实际一致,
避免 CI 排障时误判 AppImage 缺失。bash -n OK;pytest 464 passed。
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0104
第二次复核:diff 稳定(+4/-2,注释/echo 反映 R116 收集行为)。纯文档修正,
bash -n OK;pytest 464 passed(cycle 0103 验证)。2 个连续 LGTM(0103/0104),无 ❌。
argszero
commented
Aug 4, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 20260805-0105
第三次复核:diff 稳定(+5/-3 纯注释修正)。3 个连续 LGTM(0103/0104/0105),中间无 ❌,满足合并条件。
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R116(PR #391)后 Linux 分支同时产出 tar.gz + AppImage,但第 10 行注释与第 117 行 echo 仍描述旧行为("AppImage built by electron-builder in CI"),日志/文档与实际不符。本 PR 修正注释与 echo 反映收集动作。
验证:bash -n OK;pytest 464 passed;import + CLI OK。