Skip to content

emrg: recognize 'remote end hung up' as connection error in https→ssh fallback - #566

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/hung-up-connection-marker
Aug 8, 2026
Merged

emrg: recognize 'remote end hung up' as connection error in https→ssh fallback#566
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/hung-up-connection-marker

Conversation

@pm25coder

Copy link
Copy Markdown
Collaborator

Follow-up to #565 (https→ssh fallback): the `_CONNECTION_ERROR_MARKERS` list missed git's classic mid-transfer network-drop message.

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-093703

Reviewed + verified locally (worktree on fork head 2cf43dd):

  • 590 tests pass (master 589 + 1 new positive test for the 'hung up' marker)
  • Positive/negative state check (#455): 'hung up' added to _CONNECTION_ERROR_MARKERS — correct because fatal: the remote end hung up unexpectedly is git's classic network-drop message (mid-transfer proxy/network failure), exactly the case where an SSH retry may succeed. Negative states verified: auth ('Permission denied', 'Authentication failed'), 404 ('Repository not found') and empty stderr all still rejected — 'hung up' cannot appear in those.
  • Doc-count guard (#511): Agent.md + README.md 589→590 consistent; CI run 31232990694 SUCCESS.

Good narrow follow-up to #565.

@argszero
argszero merged commit 4e33893 into argszero:masterAug 8, 2026
1 check passed

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-093759

Reviewed the full diff (4 files, +20/−2) on top of #565:

  • Correct signal: hung up is git's classic mid-transfer network-drop marker (fatal: the remote end hung up unexpectedly / curl 92 ... hung up unexpectedly). Exactly the case where an SSH retry may succeed.
  • Verification both states (#455/#461): positive tested for both the single-line and the multi-line RPC-failed forms; negative manually re-checked — auth (Permission denied, Authentication failed), 404 (Repository not found), private-repo and username-prompt errors all stay rejected (no false positives).
  • Narrow blast radius: substring is distinctive; cannot collide with non-connection git errors.
  • Tests: tests/test_git_utils.py 25 passed on the branch; doc-count bump 589→590 matches the suite.

Approve-ready.

argszero added a commit that referenced this pull request Aug 8, 2026
…emote-tracking refs (#567)
* emrg: evolution prompt Step 2.2 uses FETCH_HEAD — robust to missing remote-tracking refs
* emrg: bump test count 590→591 after #566 merge (doc-count guard #511)
---------
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pm25coder@argszero