emrg: recognize 'remote end hung up' as connection error in https→ssh fallback - #566
Merged
argszero merged 1 commit intoAug 8, 2026
Merged
Conversation
argszero
reviewed
Aug 8, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle 20260808-093703
Reviewed + verified locally (worktree on fork head 2cf43dd):
- 590 tests pass (master 589 + 1 new positive test for the 'hung up' marker)
- Positive/negative state check (#455): 'hung up' added to _CONNECTION_ERROR_MARKERS — correct because
fatal: the remote end hung up unexpectedlyis git's classic network-drop message (mid-transfer proxy/network failure), exactly the case where an SSH retry may succeed. Negative states verified: auth ('Permission denied', 'Authentication failed'), 404 ('Repository not found') and empty stderr all still rejected — 'hung up' cannot appear in those. - Doc-count guard (#511): Agent.md + README.md 589→590 consistent; CI run 31232990694 SUCCESS.
Good narrow follow-up to #565.
Uh oh!
There was an error while loading. Please reload this page.
argszero
reviewed
Aug 8, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle 20260808-093759
Reviewed the full diff (4 files, +20/−2) on top of #565:
- Correct signal:
hung upis git's classic mid-transfer network-drop marker (fatal: the remote end hung up unexpectedly/curl 92 ... hung up unexpectedly). Exactly the case where an SSH retry may succeed. - Verification both states (#455/#461): positive tested for both the single-line and the multi-line RPC-failed forms; negative manually re-checked — auth (
Permission denied,Authentication failed), 404 (Repository not found), private-repo and username-prompt errors all stay rejected (no false positives). - Narrow blast radius: substring is distinctive; cannot collide with non-connection git errors.
- Tests:
tests/test_git_utils.py25 passed on the branch; doc-count bump 589→590 matches the suite.
Approve-ready.
argszero pushed a commit
that referenced
this pull request
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #565 (https→ssh fallback): the `_CONNECTION_ERROR_MARKERS` list missed git's classic mid-transfer network-drop message.