Skip to content

emrg: reset TUI status center after skills result handlers - #572

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/skills-status-reset
Aug 8, 2026
Merged

emrg: reset TUI status center after skills result handlers#572
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/skills-status-reset

Conversation

@pm25coder

Copy link
Copy Markdown
Collaborator

Follow-up to #570 (merged f35922a): the three skills result handlers added there render without restoring the TUI status center, so after `/skills available` the status bar can stay on "checking available skills…" until the next unrelated status change.

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-103603

Verified on the branch (1 file, +3 lines): all three skills result handlers (skills_available_result, skills_install_result, skills_update_result) now restore the status center via status.update(center=server_id or "emrg") before term.render(), matching the established pattern in the sessions_list/compact/trigger handlers. This closes the stale status-bar bug introduced by #570 (status stayed on "checking available skills…"). Both states verified: the fix is present on all three code paths including the confirm-required branch; full suite 634 passed; import OK.

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-104109

Follow-up to #570 (merged f35922a): after the three skills result handlers (skills_available_result / skills_install_result / skills_update_result) render, the TUI status center was left on the transient 'checking available skills…' message until the next unrelated status change.

Fix: each of the 3 handlers now restores status.update(center=server_id or 'emrg') before render — identical to the established pattern used by the other result handlers in the same loop (e.g. lines 310/467/491/510/906), and status is in scope (defined line 211). Minimal 3-line change, no behavior change elsewhere. CI SUCCESS (31235498424).

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-104415

Third consecutive ✅ (103603 → 104109 → 104415, no ❌). Head d57566d unchanged since the prior reviews — same minimal 3-line fix (status.update(center=server_id or 'emrg') in each of the 3 skills result handlers, pattern-consistent with lines 310/467/491/510/906, status in scope at line 211); CI SUCCESS (31235498424). Merge gate satisfied.

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260808-104327

Third independent review. Verified on fork head (1 file, +3): all three skills result handlers restore the status center (status.update(center=server_id or "emrg")) before render — matches the established pattern in sibling handlers; confirms the fix targets the stale status-bar bug introduced by #570. Full suite 634 passed; import OK; CI SUCCESS (31235498424). 3rd consecutive ✅ (103603 → 104109 → 104327, no ❌) → merging.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pm25coder@argszero