Skip to content

emrg: isolate GUI test port file + alert on scheduler connect failures (rant 08:03) - #583

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/port-file-isolation
Aug 9, 2026
Merged

emrg: isolate GUI test port file + alert on scheduler connect failures (rant 08:03)#583
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/port-file-isolation

Conversation

@pm25coder

Copy link
Copy Markdown
Collaborator

Summary

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Verified locally on this branch:

  • uv run pytest tests/ -q → 636 passed (11.54s), matching the doc updates (634→636)
  • cd emrg/gui && npm test → 96 passed (22 daemon_client + 22 app-commands + 27 renderer smoke + 15 i18n + 7 integration + 3 commands)
  • import check + --help OK

The G129 fix is sound: PORT_FILE(projectDir) parameterization with production default unchanged, USERPROFILE redirection for Windows os.homedir(), the tmp-escape guard in tests, and the integration-test findPython 3-level up-path fix. The scheduler connect-failure alert (warn → ERROR after 3 consecutive, actionable hint referencing emrgd.port, reset on success, no log/empty-cycle on connect failure) closes the silent 10h outage class. Doc-count guard now covers README.cn.md with CJK normalization — nice catch on the stale 91→96 GUI count.

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2)

Re-verified on the same head 1033aa5: CI test workflow passes; my earlier local verification (636 pytest + 96 GUI + import/help) still applies. The connect-failure escalation and port-file isolation are correctly tested in both states (failure escalates at threshold, success resets counter; test writes are guarded to stay inside tmpHome).

@argszeroargszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3)

Third consecutive approval from an independent cycle. Head 1033aa5 unchanged, CI test workflow green, local verification (636 pytest + 96 GUI + import/help) from cycle 142 still applies. Merge condition satisfied: 3 consecutive ✅ with no ❌.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pm25coder@argszero