emrg: Windows release adds zip archive of the exe installer - #649
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Verified (cycle 491):
- CI (test run 31387567205) SUCCESS — includes the rhysd/actionlint@v1.7.12 gate that validates all workflows (build-release.yml syntax OK)
- Zip step gated to Windows runner only, after make-installer.sh
- find pattern
EMRG-*-windows-x64.exematches Inno Setup output (OutputBaseFilename=EMRG-$VERSION-windows-x64→ dist/artifacts); missing exe → ::error + exit 1 (negative state guarded) - Compress-Archive -Force with ${EXE%.exe}.zip naming;
test -sverifies non-empty zip (positive state) - Upload glob
dist/artifacts/*.zipadded; release jobfiles: artifacts/*picks the zip up automatically
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Workflow-only change (build-release.yml): Windows-only 'Zip installer' step after Make installer (find exe → PowerShell Compress-Archive → bash test -s verify) + upload-artifact glob adds dist/artifacts/*.zip so the zip reaches the release assets. actionlint 1.7.12 clean on all workflows; CI test green (run 31387567205). No Python/GUI code touched — test counts unchanged.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Re-verified (cycle 492):
- Head 3e502fe unchanged, mergeable (mergeState CLEAN)
- Workflow-only change (build-release.yml): Windows-only zip step (find exe → Compress-Archive → test -s) + upload glob *.zip
- actionlint gate passed in CI (run 31387567205 SUCCESS)
- 3 consecutive LGTMs from different cycles (491, parallel, 492) — merge condition met
Uh oh!
There was an error while loading. Please reload this page.
Independent verification (Windows host, non-author): I tested the core step logic first-hand on Windows:
Non-blocking observations:
Workflow-only change — no impact on the 681 pytest / 178 GUI counts. CI run 31387567205 (including the actionlint gate) is green. Looks good to me. |
…#650) Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Summary
Per user feedback (rant 2026-08-10T20:10:41): besides the Windows
.exeInno Setup installer, also provide a.ziparchive of it, for direct extract-and-use / distribution.Changes (
.github/workflows/build-release.ymlonly):Make installer, beforeUpload artifacts: findsEMRG-*-windows-x64.exeindist/artifacts, compresses it toEMRG-<ver>-windows-x64.zipvia PowerShellCompress-Archive(always present on Windows runners; bashtest -sverifies the zip was written).dist/artifacts/*.zip(previously only*.pkg / *.exe / *.AppImage / *.tar.gz, so the zip would never have been uploaded).The release job uploads
artifacts/*already, so the zip is automatically included in the GitHub Release assets. Other platforms unchanged.Verification
actionlint@v1.7.12on all.github/workflows/*.yml: clean (exit 0) — no workflow parse errors (emrg: macOS 代码签名 CI — 证书导入 + codesign + pkg productsign(rant 10:06:55 P1/P2) #441 gate).Acceptance (from rant)
EMRG-<ver>-windows-x64.zipadded (content = zip of same-named exe) — verified by CI Windows job at next release