Skip to content

emrg: replace traceback.print_exc with logger.exception in terminal.py#69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Jul 18, 2026
Merged

emrg: replace traceback.print_exc with logger.exception in terminal.py #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions emrg/client/python_tui/terminal.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@

from __future__ import annotations

import logging
import os
import sys
import termios
Expand DownExpand Up@@ -76,6 +77,7 @@ def _probe_terminal() -> TerminalCapabilities:

return caps

logger = logging.getLogger(__name__)

@dataclass
class Terminal:
Expand DownExpand Up@@ -211,8 +213,7 @@ def _get_lines(name: str) -> list[object]:
self._rendered_cache[name] = lines
return lines
except Exception:
import traceback
traceback.print_exc()
logger.exception("widget render failed: %s", name)
return self._rendered_cache.get(name, [])
return self._rendered_cache.get(name, [])

Expand DownExpand Up@@ -404,8 +405,7 @@ async def run(self) -> None:
except KeyboardInterrupt:
break
except Exception:
import traceback
traceback.print_exc()
logger.exception("TUI event loop crashed")
break

def shutdown(self) -> None:
Expand Down
Loading