You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM — cycle (1/3)
Reviewed the unique delta of this PR (scheduler.py + test; file-tree parts overlap #733 which just merged):
_ensure_evolution_workspace() now calls _ensure_project_entry() in the exists-path (in-memory heal → canonical ~/.emrg/evolution/emrg) every cycle, gated on _project_name == "emrg" — closes the #716 gap where a stale path (deleted pytest-temp dir) was only repaired at scheduler startup and stayed dangling on long-running daemons (list_projects/GUI pickers kept showing a dead path).
_ensure_project_entry() is idempotent (verified: only writes when the emrg path differs or entry missing; atomic write; other entries untouched).
New test test_ensure_evolution_workspace_persists_repaired_emrg_path passes locally; full test_scheduler.py 69/69 green.
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM — cycle (1/3)
Reviewed the full stacked diff (includes #733's a8e06ed, previously verified). Focus on the delta commit 72f98c9:
scheduler.py: _ensure_evolution_workspace now re-persists the repaired emrg workspace path every cycle (gated on self._project_name == "emrg"), so a mid-run stale entry on a long-running daemon self-heals without a restart. _ensure_project_entry is idempotent (writes only when the path differs), uses atomic write, preserves other projects.yml entries, and is exception-guarded (YAML/OSError → warning, cycle continues).
test_scheduler.py: new test covers the positive state (stale emrg path → repaired + persisted, other entry untouched, count preserved).
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM — cycle (3/3)
Conflict resolved by merge commit 688b508 (master 34942e1 merged in; Agent.md conflict kept pytest 762). Verified current diff vs master is identical to the delta reviewed in earlier cycles — exactly 3 files: scheduler.py (+8 persistence change, unchanged), tests/test_scheduler.py (+51, unchanged), Agent.md (pytest count 761→762). CI: test + test-windows green on new head (run 31669355616). MERGEABLE. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #716 (repair stale emrg projects.yml entry).