Skip to content

emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 14, 2026
Merged

emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Agent.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
- Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
- Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
- Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
- Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
- Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
- Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down
11 changes: 8 additions & 3 deletions emrg/gui/renderer/js/dialogs.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
actions.appendChild(trigBtn);
// 编辑（表单预填 → taskUpdate）
const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
editBtn.addEventListener("click", () => openTaskForm(t));
editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
actions.appendChild(editBtn);
// 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
}
}

function openTaskForm(task = null) {
async function openTaskForm(task = null) {
// rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
// 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
if (taskTypes.length === 0 && taskProjects.length === 0) {
await loadTaskMeta();
}
editingTask = task ? task.name : null;
$("task-form-name").value = task ? task.name : "";
$("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

function initTaskManagement() {
const addBtn = $("task-add-btn");
if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
const saveBtn = $("task-form-save");
if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
const cancelBtn = $("task-form-cancel");
Expand Down
42 changes: 42 additions & 0 deletions emrg/gui/test/renderer.smoke.test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
let created = null;
const { ctx, els } = makeSandbox({
listTasks: async () => [],
// 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
taskTemplateList: async () => {
await new Promise((r) => setTimeout(r, 50));
return [
{ name: "evolution", builtin: true, template: "evolution_prompt.md" },
{ name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
];
},
listProjects: async () => {
await new Promise((r) => setTimeout(r, 50));
return [{ name: "emrg", path: "/p/emrg" }];
},
taskCreate: async (payload) => { created = payload; return { ok: true }; },
});
await tick();
// 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
vm.runInContext("App.openTasksPanel()", ctx);
els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
// 元数据还在加载（50ms 未到）就点"＋ 添加任务"
await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
// 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
await new Promise((r) => setTimeout(r, 120));
await tick();
// 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
// 填任务名 → 保存 → taskCreate payload type/project 非空
vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
await tick();
assert.ok(created, "快速点击保存应成功（不报 invalid type）");
assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
assert.strictEqual(created.type, "evolution");
assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
let createdTpl = null;
let deletedTpl = null;
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52) by argszero · Pull Request #789 · argszero/emrg · GitHub
Skip to content
emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)#789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 14, 2026
 Merged


emrg: fix GUI task form empty dropdowns on quick add (rant 2026-08-14T15:41:52)
#789
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.port; python -m emrg
```

Python: `uv run pytest tests/ -v` (805) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (245: 44 daemon_client + 19 conn-manager + 22 app-commands + 120 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (246: 44 daemon_client + 19 conn-manager + 22 app-commands + 121 renderer smoke + 16 i18n + 7 integration + 3 commands + 5 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

11 changes: 8 additions & 3 deletions
emrg/gui/renderer/js/dialogs.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -672,7 +672,7 @@ const Dialogs = (() => {
 actions.appendChild(trigBtn);
 // 编辑（表单预填 → taskUpdate）
 const editBtn = el("button", { type: "button", class: "model-action-btn", title: _t("settings.taskEdit") }, _t("settings.taskEdit"));
 editBtn.addEventListener("click", () => openTaskForm(t));
 editBtn.addEventListener("click", () => { openTaskForm(t).catch(() => {}); });
 actions.appendChild(editBtn);
 // 删除（确认弹窗 → taskDelete → 热重载由 daemon apply_tasks 完成）
 const delBtn = el("button", { type: "button", class: "model-action-btn danger", title: _t("settings.taskDelete") }, _t("settings.taskDelete"));
Expand All@@ -697,7 +697,12 @@ const Dialogs = (() => {
 }
 }

 function openTaskForm(task = null) {
 async function openTaskForm(task = null) {
 // rant 2026-08-14T15:41:52：点"＋ 添加任务"时元数据未加载完 → 下拉为空 → 保存报 invalid type
 // 幂等快路径：openTasksPanel/保存刷新已加载过 → 同步填（无闪烁）；未完成 → 等 IPC 返回再填
 if (taskTypes.length === 0 && taskProjects.length === 0) {
 await loadTaskMeta();
 }
 editingTask = task ? task.name : null;
 $("task-form-name").value = task ? task.name : "";
 $("task-form-name").disabled = Boolean(task); // 决策点：daemon 以 name 定位 → 不可改名
Expand DownExpand Up@@ -863,7 +868,7 @@ const Dialogs = (() => {

 function initTaskManagement() {
 const addBtn = $("task-add-btn");
 if (addBtn) addBtn.addEventListener("click", () => openTaskForm(null));
 if (addBtn) addBtn.addEventListener("click", () => { openTaskForm(null).catch(() => {}); });
 const saveBtn = $("task-form-save");
 if (saveBtn) saveBtn.addEventListener("click", saveTaskForm);
 const cancelBtn = $("task-form-cancel");
Expand Down

42 changes: 42 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2660,6 +2660,48 @@ test("P3：新增任务表单 —— 间隔 <60 客户端拒绝；≥60 提交 t
 assert.strictEqual(vm.runInContext('document.getElementById("task-form").classList.contains("hidden")', ctx), true, "保存后表单收起");
});

test("rant 2026-08-14T15:41:52：快速点击添加任务 —— 元数据未加载完也填充下拉 + 保存成功", async () => {
 let created = null;
 const { ctx, els } = makeSandbox({
 listTasks: async () => [],
 // 延迟返回（50ms）→ 复现"打开面板后立即点添加"竞态（loadTaskMeta 未完成）
 taskTemplateList: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [
 { name: "evolution", builtin: true, template: "evolution_prompt.md" },
 { name: "custom-a", builtin: false, template: "custom-a.md", prompt: "# a" },
 ];
 },
 listProjects: async () => {
 await new Promise((r) => setTimeout(r, 50));
 return [{ name: "emrg", path: "/p/emrg" }];
 },
 taskCreate: async (payload) => { created = payload; return { ok: true }; },
 });
 await tick();
 // 打开任务面板（fire-and-forget，不等 loadTaskMeta —— 复现宿主"点 ⏱ 立即点添加"）
 vm.runInContext("App.openTasksPanel()", ctx);
 els["task-form"].classList.add("hidden"); // 镜像 index.html 初始态
 // 元数据还在加载（50ms 未到）就点"＋ 添加任务"
 await vm.runInContext('document.getElementById("task-add-btn").click()', ctx);
 // 等 openTaskForm 内 await loadTaskMeta() 完成（50ms 延迟 + 缓冲）
 await new Promise((r) => setTimeout(r, 120));
 await tick();
 // 下拉应有选项（修复前：0 个选项 → 保存报 invalid type → 界面"没反应"）
 const typeOpts = vm.runInContext('Array.from(document.getElementById("task-form-type").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(typeOpts.sort(), ["custom-a", "evolution"]);
 const projOpts = vm.runInContext('Array.from(document.getElementById("task-form-project").children).map((o) => o.value)', ctx);
 assert.deepStrictEqual(projOpts, ["emrg"], "项目下拉应含已注册项目");
 // 填任务名 → 保存 → taskCreate payload type/project 非空
 vm.runInContext('document.getElementById("task-form-name").value = "quick-task"', ctx);
 await vm.runInContext("EMRG_Dialogs.saveTaskForm()", ctx);
 await tick();
 assert.ok(created, "快速点击保存应成功（不报 invalid type）");
 assert.ok(created.type && created.project, `type/project 非空：${JSON.stringify(created)}`);
 assert.strictEqual(created.type, "evolution");
 assert.strictEqual(created.project, "emrg");
});

test("P3：自定义类型管理 —— 内置只读；自定义增删改走模板 CRUD", async () => {
 let createdTpl = null;
 let deletedTpl = null;
Expand Down
Loading