emrg: move EVOLUTION_CWD to module level, fix AttributeError in EmrgServer - #82
Merged
Merged
Conversation
…erver EmrgServer._touch_project and _handle_list_projects referenced self.EVOLUTION_CWD, but EVOLUTION_CWD was a class constant on BackgroundThread — not inherited by EmrgServer — causing AttributeError whenever a client connected. Moved EVOLUTION_CWD to a module-level constant (before both classes), kept a class alias in BackgroundThread for backward compatibility, and updated the two EmrgServer call sites to use the module-level name.
argszeroforce-pushed
the
fix/evolution-cwd-attributeerror
branch
from
July 20, 2026 04:40
196f87b to
18d9b92Compareargszero
commented
Jul 20, 2026
argszero
commented
Jul 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
EmrgServer._touch_projectand_handle_list_projectsreferencedself.EVOLUTION_CWD, butEVOLUTION_CWDwas only defined as a class constant onBackgroundThread. SinceEmrgServerdoes not inherit fromBackgroundThread, this caused anAttributeErrorcrash whenever a client connected and_touch_projectwas called.Changed
EVOLUTION_CWDto a module-level constant (before both class definitions)EVOLUTION_CWD = EVOLUTION_CWDinBackgroundThreadfor backward compatibilityEmrgServercall sites (_touch_project,_handle_list_projects) to use the module-level nameVerification
pytest: 239 passed--help: OK