emrg: fix electron-builder buildResources schema (v0.2.47 build gate) - #838
Merged
Conversation
added 2 commits
August 18, 2026 13:36
#836 placed buildResources at the config root — electron-builder 24.13.3 rejects the unknown property and all 4 Build Release jobs fail at the electron-builder schema validation stage. Correct location is directories.buildResources. Adds a build-config guard test so the schema constraint is enforced at PR-CI time (Test CI never runs electron-builder, only the tag-triggered Build Release does).
…nored gen-assets products icon.icns/ico/png are gitignored build-time products (packaging/gen-assets.sh renders them from icon.svg); CI checks out fresh and fails the exists-check. Guard now asserts the committed design source icon.svg exists + the schema constraint (directories.buildResources placement).
argszero
commented
Aug 18, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 708 (1/3). CI test + test-windows PASS (32103844522). electron-builder config schema validated locally — directories.buildResources resolves to ../packaging/assets. Fix addresses the v0.2.47 4/4 Build Release schema failure.
argszero
commented
Aug 18, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle 709 (2/3). Head 3366136, CI test + test-windows PASS (32103844522). Re-verified: buildResources moved to directories.buildResources, guard asserts committed icon.svg (gen-assets products are gitignored — correct for CI). Schema validated locally via getConfig.
Uh oh!
There was an error while loading. Please reload this page.
argszero pushed a commit
that referenced
this pull request
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.47 Build Release failed on all 4 build jobs: electron-builder 24.13.3 rejects the root-level
buildResourceskey added by #836 ("configuration has an unknown property 'buildResources'"). The schema requires it underdirectories.buildResources.Changes
emrg/gui/package.json: movebuildResourcesfrom config root todirectories.buildResourcesemrg/gui/test/build-config.test.js: new schema guard — fails ifbuildResourcesappears at root, requiresdirectories.buildResources = ../packaging/assets, and asserts the three icon sources (icon.icns/ico/png) exist inpackaging/assetsAgent.md: GUI test count 257→258 (new guard test)Why the guard: Test CI never runs
electron-builder(only the tag-triggered Build Release does) — #836 passed Test CI but broke packaging. The guard makes the schema constraint fail at PR-CI time.Refs: rant 2026-08-18T12:45:47 (release v0.2.47); Build Release 32102801333 failure logs.