emrg: task recent-runs subtable + vibe-check done summary (rant 2026-08-18T21:32:32) - #855
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. CI test + test-windows both PASS (run 32157262069). Verified: py_compile + import + in-memory status() recent_runs + npm test 260/260 locally.
argszero
commented
Aug 18, 2026
Note: the final test-count change is +3 Python (955→958) +1 GUI (259→260); the PR description said 959 — corrected in the fix commit (Agent.md now 958, doc-count guard green on CI). |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2/3). Re-verified head 1e61ace unchanged, full diff reviewed (daemon vibe-check done field + EvolutionLog fields + scheduler recent_runs + GUI accordion subtable + tests). CI test + test-windows PASS (run 32157262069). Backward-compatible fallbacks confirmed: missing 'done' → empty summary; vibe unavailable → completion first-line fallback; GUI old data → impact join.
Uh oh!
There was an error while loading. Please reload this page.
What & why
Host rant 2026-08-18T21:32:32: the GUI tasks panel shows a machine string (
cycle-<ts>-complete, tools-executed=N) as "what it did". Two asks:Changes
Python (daemon → log → status):
emrg/server/daemon.py_task_vibe_check: prompt JSON format extended with"done": "这次干了哪些有意义有价值的事"; result now includesdone(truncated to 500 chars). Missingdonefrom old models →""(backward compatible).emrg/protocol.pyEvolutionLog: new fieldssummary,meaningful,recommend_slowdown,tool_count.emrg/server/scheduler.py:_request_vibe_checkpassesdonethrough._run_evolution_cyclefills the log fields from the vibe result; fallback: vibe unavailable →meaningful=Noneand summary = first line of completion content (never crash)._write_evolution_logpersists the new fields.status()addsrecent_runs(last 5 evolutions: timestamp/summary/impact/meaningful/recommend_slowdown/tool_count);last_cycle_summarynow prefers the agent summary over impact tags. All in-memory —list_tasksstays pure (rant 2026-08-18T20:48:45).GUI:
renderer/js/dialogs.js: clicking a task card (not a button) toggles an accordion subtable — 时间 / 干了什么 / 降频 columns; agent summary shown, fallback to impact join for old data; "建议降频" badge whenrecommend_slowdown, "空转" badge whenmeaningful=false; "暂无运行记录" placeholder when no runs.renderer/js/i18n.js: 6 new keys (zh + en).renderer/css/components.css: subtable styles.Tests (+4: 955→959 Python, 259→260 GUI):
tests/test_ws_e2e.py: vibe check returnsdone; missing-donecompatibility.tests/test_scheduler.py: statusrecent_runs+ summary preference; recent_runs capped at 5; log summary fallback paths.emrg/gui/test/renderer.smoke.test.js: click-to-expand subtable (summary / badges / impact fallback / empty placeholder).Verification
python3 -m py_compileall changed Python files ✓uv run pythonimport + in-memorystatus()recent_runs check ✓npm test(GUI): 260/260 pass ✓