Skip to content

emrg: task recent-runs subtable + vibe-check done summary (rant 2026-08-18T21:32:32) - #855

Merged
argszero merged 2 commits into
masterfrom
feature/task-recent-runs-vibe-summary
Aug 18, 2026
Merged

emrg: task recent-runs subtable + vibe-check done summary (rant 2026-08-18T21:32:32)#855
argszero merged 2 commits into
masterfrom
feature/task-recent-runs-vibe-summary

Conversation

@argszero

Copy link
Copy Markdown
Owner

What & why

Host rant 2026-08-18T21:32:32: the GUI tasks panel shows a machine string (cycle-<ts>-complete, tools-executed=N) as "what it did". Two asks:

  1. Clicking a task card should expand a recent-runs subtable (time / what was done / throttle flag).
  2. "What was done" should be the agent's own natural-language summary of meaningful work, captured at vibe-check time — not a machine tag.

Changes

Python (daemon → log → status):

  • emrg/server/daemon.py_task_vibe_check: prompt JSON format extended with "done": "这次干了哪些有意义有价值的事"; result now includes done (truncated to 500 chars). Missing done from old models → "" (backward compatible).
  • emrg/protocol.pyEvolutionLog: new fields summary, meaningful, recommend_slowdown, tool_count.
  • emrg/server/scheduler.py:
    • _request_vibe_check passes done through.
    • _run_evolution_cycle fills the log fields from the vibe result; fallback: vibe unavailable → meaningful=None and summary = first line of completion content (never crash).
    • _write_evolution_log persists the new fields.
    • status() adds recent_runs (last 5 evolutions: timestamp/summary/impact/meaningful/recommend_slowdown/tool_count); last_cycle_summary now prefers the agent summary over impact tags. All in-memory — list_tasks stays pure (rant 2026-08-18T20:48:45).

GUI:

  • renderer/js/dialogs.js: clicking a task card (not a button) toggles an accordion subtable — 时间 / 干了什么 / 降频 columns; agent summary shown, fallback to impact join for old data; "建议降频" badge when recommend_slowdown, "空转" badge when meaningful=false; "暂无运行记录" placeholder when no runs.
  • renderer/js/i18n.js: 6 new keys (zh + en).
  • renderer/css/components.css: subtable styles.

Tests (+4: 955→959 Python, 259→260 GUI):

  • tests/test_ws_e2e.py: vibe check returns done; missing-done compatibility.
  • tests/test_scheduler.py: status recent_runs + summary preference; recent_runs capped at 5; log summary fallback paths.
  • emrg/gui/test/renderer.smoke.test.js: click-to-expand subtable (summary / badges / impact fallback / empty placeholder).

Verification

  • python3 -m py_compile all changed Python files ✓
  • uv run python import + in-memory status() recent_runs check ✓
  • npm test (GUI): 260/260 pass ✓
  • Local Python test run skipped per host temp ban until 08-19 — CI gate covers it (test + test-windows matrix).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle. CI test + test-windows both PASS (run 32157262069). Verified: py_compile + import + in-memory status() recent_runs + npm test 260/260 locally.

@argszero

Copy link
Copy Markdown
OwnerAuthor

Note: the final test-count change is +3 Python (955→958) +1 GUI (259→260); the PR description said 959 — corrected in the fix commit (Agent.md now 958, doc-count guard green on CI).

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (2/3). Re-verified head 1e61ace unchanged, full diff reviewed (daemon vibe-check done field + EvolutionLog fields + scheduler recent_runs + GUI accordion subtable + tests). CI test + test-windows PASS (run 32157262069). Backward-compatible fallbacks confirmed: missing 'done' → empty summary; vibe unavailable → completion first-line fallback; GUI old data → impact join.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3). Merge gate satisfied: 3 consecutive LGTMs from different cycles, no ❌ in between. Head 1e61ace unchanged, CI test + test-windows PASS, mergeState CLEAN.

@argszero
argszero merged commit c963005 into masterAug 18, 2026
2 checks passed
@argszero
argszero deleted the feature/task-recent-runs-vibe-summary branch August 18, 2026 16:03
argszero added a commit that referenced this pull request Aug 18, 2026
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@argszero