emrg: GUI task primary/secondary list — drop last_cycle_summary from primary row + add reason column to run detail - #873
Merged
Conversation
… reason column (rant 2026-08-19T18:25:14)
- Primary task row no longer shows last_cycle_summary ('what was done');
execution records moved entirely to the click-to-expand secondary list.
- Scheduler now persists the vibe-check 'reason' field in EvolutionLog and
exposes it via status() recent_runs (time/work/throttle/reason columns).
- i18n: new app.taskRunsColReason key (zh/en); orphaned taskLastRunSummary
removed. CSS grid widened to 4 columns with ellipsized reason cell.argszero
commented
Aug 19, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle
Verified:
- diff is 7 files / +45 −13, scoped to the rant's requirement (primary row drops last_cycle_summary; accordion gains a Reason column fed by a newly persisted vibe-check
reasonfield). - Scheduler
status()recent_runs now carriesreason; EvolutionLog dataclass extended; no daemon API shape changes elsewhere. - i18n: new
app.taskRunsColReason(zh/en), orphanedapp.taskLastRunSummaryremoved — orphan/missing-key guard passes. - Local verification: Python suite 976 passed + 1 skipped (977 collected, matches Agent.md); GUI i18n + renderer smoke 147/147; daemon_client 45/45; import + CLI OK.
- CI: test job PASS. (test-windows still running; integration tests need an isolated daemon so they are skipped locally by design while the daemon holds the fixed port.)
argszero
commented
Aug 19, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle (2nd)
Re-verified in this cycle:
- Head unchanged (6f4b09b, 7 files / +45 −13); MERGEABLE.
- Change is scoped and consistent: primary row drops
last_cycle_summary; accordion gains Reason column fed by the newly persisted vibe-checkreason(EvolutionLog + status().recent_runs); i18n orphanapp.taskLastRunSummaryremoved; CSS grid 4 cols. - Local: Python suite 976 passed + 1 skipped (977 = Agent.md); GUI i18n+smoke 147/147; daemon_client 45/45; import + CLI OK.
- CI: original run's test job PASS; the Windows job was queue-stuck for 35+ min (same start time as the 1m25s linux job) — cancelled and re-triggered via workflow_dispatch (run 32245064133), now in progress.
…s job from cancelled run)
argszero
commented
Aug 19, 2026
argszero
left a comment
OwnerAuthor
There was a problem hiding this comment.
✅ LGTM — cycle (3rd)
Final verification:
- Head b369899 (empty re-check commit on top of 6f4b09b, no code change — supersedes the cancelled Windows check from the old run); mergeStateStatus CLEAN, MERGEABLE.
- Fresh pull_request run 32245663591: test PASS (1m34s) + test-windows PASS (58s).
- Local verification from cycles 930/931 stands: Python 976+1=977, GUI i18n+smoke 147/147, daemon_client 45/45, import + CLI OK.
- 3 consecutive LGTMs (cycles 930/931/932), no ❌ between → merging.
Uh oh!
There was an error while loading. Please reload this page.
argszero added a commit
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes host rant 2026-08-19T18:25:14 (GUI 任务管理·一级/二级列表).
Problem
last_cycle_summary("what was done") inline, cluttering the row.Changes
emrg/gui/renderer/js/dialogs.js: primary task row no longer renderslast_cycle_summary; accordion head/rows gain a 4thReasoncolumn (app.taskRunsColReason).emrg/server/scheduler.py+emrg/protocol.py:EvolutionLoggainsreason; the vibe-checkreasonfield (natural-language judgment explanation) is now persisted and surfaced instatus()recent_runs.emrg/gui/renderer/js/i18n.js: newapp.taskRunsColReasonkey (zh/en); orphanedapp.taskLastRunSummaryremoved (no longer referenced).emrg/gui/renderer/css/components.css: run-detail grid widened to 4 columns (72px / 1fr / 92px / 1fr) + ellipsized.task-run-reason.recent_runsreason assertions; GUI accordion test asserts reason column + primary list no longer shows the summary.Verification
Note: GUI integration tests are skipped locally while the daemon holds the fixed port (single-instance admission); they run in CI's isolated environment.