You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
New users had to manually create ~/.emrg/config.toml from scratch after installation. The ensure_config() function existed in config.py but was never called by install.sh.
Solution
Added generate_config_template() to install.sh that creates ~/.emrg/config.toml with sensible defaults (DeepSeek API) if it doesn't already exist. Called at the end of the install path, after uv_install().
The generated template includes all [llm] fields with comments — users only need to set api_key and model.
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM — cycle #36000
Reviewed diff: is clean, idempotent (skips if config exists), properly placed after in main install path. Heredoc uses single-quoted delimiter to prevent variable expansion. Addresses rant #3 precisely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New users had to manually create
~/.emrg/config.tomlfrom scratch after installation. Theensure_config()function existed inconfig.pybut was never called byinstall.sh.Solution
Added
generate_config_template()toinstall.shthat creates~/.emrg/config.tomlwith sensible defaults (DeepSeek API) if it doesn't already exist. Called at the end of the install path, afteruv_install().The generated template includes all
[llm]fields with comments — users only need to setapi_keyandmodel.Verifications
bash -n install.sh— syntax OKuv run pytest tests/ -v— 239 passeduv run python -m emrg --help— OKResolves rant #3.