Skip to content

emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 22, 2026
Merged

emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Agent.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
- Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
- Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
- Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
- Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
- Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
- Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down
6 changes: 6 additions & 0 deletions emrg/gui/renderer/js/app.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
if (sidState(sid).disconnected) {
Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
}
// rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
// 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
// 递归/初始化路径用 silent，不会在这里触发重复 switchView。
if (!opts.silent && state.activeView !== "sessions") {
switchView("sessions");
}
updateEmptyState();
Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down
11 changes: 11 additions & 0 deletions emrg/gui/test/renderer.smoke.test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
const { ctx } = makeSandbox({ switchSession: async () => ({}) });
await tick();
// 模拟任务面板激活 → 点"打开会话" → switchSession
await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
await vm.runInContext('App.switchSession("sess-a");', ctx);
await tick();
assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
let closed = null;
const { ctx, els } = makeSandbox({
Expand Down
8 changes: 8 additions & 0 deletions emrg/server/promote_prompt.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback by argszero · Pull Request #932 · argszero/emrg · GitHub
Skip to content
emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback#932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

argszero
merged 1 commit into

from

Aug 22, 2026
 Merged


emrg: fix open-session returning to session view + add GitHub issue path to promotion feedback
#932
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


4 changes: 2 additions & 2 deletions
Agent.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,7 +85,7 @@ Usage: say "tool loop" for the whole process, "round N" for a single LLM request
 - Streaming chat with delta rendering (16ms batching), markdown on done (marked + DOMPurify + local highlight.js subset), tool call status cards (2000-char truncation + expand)
 - Session list/switch/new/delete + right-click rename (context menu, #423) synced with daemon; own-stream busy lock (G65); broadcast streams from other clients tagged "来自其他客户端"
 - Disconnect/reconnect: red status dot, auto daemon respawn (stale-port detection), session resume, input bar restored on disconnect (no 30s fake-timeout)
 - Unit tests `npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
 - Unit tests `npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group); RESPONSE_TYPES mirror daemon protocol verified against `daemon.py`
- **Scheduled tasks** — Task generalization + CRUD (rant 2026-08-12T18:23:15, #709/#710/#711)
 - Task handler generalized: `TaskHandler` (renamed from `EvolutionHandler`), repo-configured self-heal for any project, template lookup builtin → `~/.emrg/task-templates/<name>.md` → fallback
 - Daemon commands: `task_create/update/delete` + `task_template_create/list/update/delete` (tasks stored in `~/.emrg/tasks.yml`, custom type templates in `~/.emrg/task-templates/`)
Expand DownExpand Up@@ -119,7 +119,7 @@ pkill -f "emrg.server"; rm -f ~/.emrg/emrgd.token; python -m emrg
```

Python: `uv run pytest tests/ -v` (1003) — import check: `uv run python -c "from emrg.client.app import run_client"`
GUI: `cd emrg/gui && npm test` (258: 45 daemon_client + 19 conn-manager + 22 app-commands + 129 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
GUI: `cd emrg/gui && npm test` (259: 45 daemon_client + 19 conn-manager + 22 app-commands + 130 renderer smoke + 15 i18n + 8 integration + 3 commands + 8 build-config + 7 gui-state + 2 tool-group) — syntax: `node --check main.js preload.js daemon_client.js renderer/js/*.js`
CI: `uv run pytest` (ubuntu + **windows-2025 matrix** — Windows pytest 回归在 PR CI 即失败，v0.2.29 教训 #725) + GUI tests + **actionlint workflow lint** (`rhysd/actionlint@v1.7.12` gate, #444 — workflow 解析错误在 PR CI 即失败，如 `if:` secrets 上下文)
Re-trigger: `scripts/re-trigger-ci.sh [branch]` (workflow_dispatch, #527 — 替代空 commit 重触发：Actions outage 会整段丢弃 push 事件，dispatch 走 API 路径不受影响)

Expand Down

6 changes: 6 additions & 0 deletions
emrg/gui/renderer/js/app.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -668,6 +668,12 @@ const App = (() => {
 if (sidState(sid).disconnected) {
 Chat.addSystemMessage(_t("app.sessionDisconnected"), sid);
 }
 // rant 2026-08-22T08:07:47：任务/rant/项目面板点"打开会话"只切 sessionId 不切视图，
 // 界面毫无变化。switchSession 成功后若仍在面板视图则切回会话视图（所有入口一致）。
 // 递归/初始化路径用 silent，不会在这里触发重复 switchView。
 if (!opts.silent && state.activeView !== "sessions") {
 switchView("sessions");
 }
 updateEmptyState();
 Sidebar.highlight(sid, opts.scopeNav); // rant 22:04:02：点击哪列表只高亮该列表（scopeNav 缺省则两列表）
 setComposerDisabled(false); // 防御性：独立调用 switchSession 也确保输入框可用
Expand Down

11 changes: 11 additions & 0 deletions
emrg/gui/test/renderer.smoke.test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -2081,6 +2081,17 @@ test("rant 22:04:02: highlight(sid, navEl) 列表作用域 — 只高亮指定
 assert.strictEqual(els["open-sessions"].children[0].classList.contains("active"), true, "无 navEl 时 open-sessions 高亮");
});

test("rant 08:07:47: switchSession 从面板视图调用成功 → 切回会话视图", async () => {
 const { ctx } = makeSandbox({ switchSession: async () => ({}) });
 await tick();
 // 模拟任务面板激活 → 点"打开会话" → switchSession
 await vm.runInContext('App.state.sessionId = "sess-a"; App.state.sessions = [{ session_id: "sess-a" }]; App.switchView("tasks");', ctx);
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "tasks", "进入任务面板后 activeView=tasks");
 await vm.runInContext('App.switchSession("sess-a");', ctx);
 await tick();
 assert.strictEqual(vm.runInContext("App.state.activeView", ctx), "sessions", "switchSession 成功后 activeView 切回 sessions（界面有响应）");
});

test("P4 s2: closeOpenSession 关闭激活会话 → 切到剩余打开会话 + 容器释放", async () => {
 let closed = null;
 const { ctx, els } = makeSandbox({
Expand Down

8 changes: 8 additions & 0 deletions
emrg/server/promote_prompt.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -246,6 +246,14 @@ with open(rants_file, "w", encoding="utf-8") as f:
- Use `json.dumps(..., ensure_ascii=False)`; no Chinese escaping
- Each message notes the source (channel + link) so the evolution task can trace back

**Also file a public GitHub issue on the promoted project** (rant 2026-08-22T08:14:31) — a rant is an internal queue (no issue number, not community-visible); a public issue is transparent, traceable, and lets the community participate. For **valuable feedback** (same table above — feature request / bug report / negative experience / new problem / inspiration):

1. Open a public issue on the target repo: `gh issue create -R {{ owner }}/{{ repo }} --title "<English title>" --body "<feedback summary> (source: <channel> <link>)"` — English title/body (language policy), body includes the source link for traceability.
2. On success → record the issue number + link in the state file (e.g. `- filed issues: <#N> (<summary>, <link>)`), and optionally reference that issue number in the rant entry to avoid the evolution task re-processing the same feedback.
3. Reuse the existing value table for the bar; **do NOT file** for pure praise / unrelated / duplicate / low-information. Do not over-encourage the community: only nudge someone to file an issue themselves if **both** hold (per host 2026-08-22): (a) the discussion already explicitly referenced the promoted project, and (b) you judge them likely willing (engaged / interested / proactively asking). Otherwise **file it yourself** (the `gh issue create` path above) rather than nudging.
4. If the target repo has issues disabled (some open-source projects), degrade to the rants.jsonl path only.
5. The promotion task does not implement these — it only collects (rant + issue) and hands off, consistent with the existing rant handoff semantics.

---

### 4. State File
Expand Down
Loading