emrg: gui: task list no internal vertical scrollbar (rant 2026-08-24T21:21:58) - #963
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 214419
Reviewed head eba663a against master: 2 files (+6/−2). Removes max-height: 220px; overflow-y: auto from .task-list (components.css) so the task panel fully expands with content — no internal vertical scrollbar when >5 tasks; adds a CSS regression assertion in renderer.smoke.test.js (.task-list must not contain max-height/overflow-y), validated in both positive and negative states. CI green (test + test-windows, run 32734716020); local GUI 252 pass / 0 fail, pytest 1049 passed / 1 skipped.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 215439
Reviewed head eba663a against master: 2 files (+6/−2). Confirms removal of max-height: 220px + overflow-y: auto from .task-list (components.css) — task panel fully expands, no internal vertical scrollbar when >5 tasks; regression assertion in renderer.smoke.test.js checks the .task-list rule must NOT contain max-height/overflow-y (validated in both positive and negative states). CI green (test + test-windows, run 32734716020). LGTM 2/3.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 221140 (3/3)
Reviewed head eba663a against master: 2 files (+6/−2). .task-list loses max-height: 220px + overflow-y: auto so the task panel expands fully (no internal vertical scrollbar when >5 tasks); renderer.smoke.test.js gains a negative-state regression assertion (.task-list must NOT contain max-height/overflow-y). CI green (test + test-windows, run 32734716020). 3 consecutive LGTMs from cycles 214419, 215439, 221140 — merging.
Uh oh!
There was an error while loading. Please reload this page.
Fix the GUI task-management list showing a vertical scrollbar that hides the last task when >5 tasks exist.
Root cause:
emrg/gui/renderer/css/components.css.task-listhadmax-height: 220px; overflow-y: auto(~44px/row → ~5 rows visible). The host has 6 tasks, so the newest one was cut off.Fix: removed
max-height+overflow-y: autofrom.task-list— the list now fully expands with content (task counts are single-digit; page-level scrolling handles any future overflow). Also applies to the shared lists (project/task-template/rant) which are equally small.Regression guard: added a CSS assertion in
test/renderer.smoke.test.js(task panel test) that.task-listmust NOT containmax-heightoroverflow-y— validated in both positive (fixed) and negative (re-introduced scrollbar → assertion fails) states.Verification: GUI 252 pass / 0 fail (260 tests); pytest 1049 passed / 1 skipped.