Skip to content

emrg: gui: task list no internal vertical scrollbar (rant 2026-08-24T21:21:58) - #963

Merged
argszero merged 1 commit into
masterfrom
feature/gui-task-list-scroll-fix
Aug 24, 2026
Merged

emrg: gui: task list no internal vertical scrollbar (rant 2026-08-24T21:21:58)#963
argszero merged 1 commit into
masterfrom
feature/gui-task-list-scroll-fix

Conversation

@argszero

Copy link
Copy Markdown
Owner

Fix the GUI task-management list showing a vertical scrollbar that hides the last task when >5 tasks exist.

Root cause: emrg/gui/renderer/css/components.css.task-list had max-height: 220px; overflow-y: auto (~44px/row → ~5 rows visible). The host has 6 tasks, so the newest one was cut off.

Fix: removed max-height + overflow-y: auto from .task-list — the list now fully expands with content (task counts are single-digit; page-level scrolling handles any future overflow). Also applies to the shared lists (project/task-template/rant) which are equally small.

Regression guard: added a CSS assertion in test/renderer.smoke.test.js (task panel test) that .task-list must NOT contain max-height or overflow-y — validated in both positive (fixed) and negative (re-introduced scrollbar → assertion fails) states.

Verification: GUI 252 pass / 0 fail (260 tests); pytest 1049 passed / 1 skipped.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 214419

Reviewed head eba663a against master: 2 files (+6/−2). Removes max-height: 220px; overflow-y: auto from .task-list (components.css) so the task panel fully expands with content — no internal vertical scrollbar when >5 tasks; adds a CSS regression assertion in renderer.smoke.test.js (.task-list must not contain max-height/overflow-y), validated in both positive and negative states. CI green (test + test-windows, run 32734716020); local GUI 252 pass / 0 fail, pytest 1049 passed / 1 skipped.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 215439

Reviewed head eba663a against master: 2 files (+6/−2). Confirms removal of max-height: 220px + overflow-y: auto from .task-list (components.css) — task panel fully expands, no internal vertical scrollbar when >5 tasks; regression assertion in renderer.smoke.test.js checks the .task-list rule must NOT contain max-height/overflow-y (validated in both positive and negative states). CI green (test + test-windows, run 32734716020). LGTM 2/3.

@argszeroargszero left a comment

Copy link
Copy Markdown
OwnerAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 221140 (3/3)

Reviewed head eba663a against master: 2 files (+6/−2). .task-list loses max-height: 220px + overflow-y: auto so the task panel expands fully (no internal vertical scrollbar when >5 tasks); renderer.smoke.test.js gains a negative-state regression assertion (.task-list must NOT contain max-height/overflow-y). CI green (test + test-windows, run 32734716020). 3 consecutive LGTMs from cycles 214419, 215439, 221140 — merging.

@argszero
argszero merged commit d68efce into masterAug 24, 2026
2 checks passed
argszero added a commit that referenced this pull request Aug 24, 2026
…r fix, #964 — per-task extra_prompt) (#965)
Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@argszero