chore: Update Rust to v1.98 by samuelburnham · Pull Request #28 · argumentcomputer/lean-ffi

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham · 2026-08-22T18:39:39Z

No description provided.

Repin the fenix toolchain hash in flake.nix; without it every nix build fails on a hash mismatch against the 1.92 pin. clippy::from_iter_instead_of_collect was removed upstream, so the xclippy alias emitted renamed_and_removed_lints. Under the CI action's default RUSTFLAGS=-D warnings that was a hard error, not a warning. Replace both warning-denial mechanisms with build.warnings, stabilized in 1.97. It applies to local packages only, so a warning in a dependency no longer fails the build, and it stays out of RUSTFLAGS, so it no longer invalidates the dependency build cache.

The alias existed because clippy had no project-wide lint configuration. Cargo's [lints] tables cover that now, so the lint set moves to [workspace.lints] and both members inherit it. CI lint jobs call cargo clippy directly with the full argument list. Dropping the alias removes .cargo/config.toml entirely, so build.warnings moves to CARGO_BUILD_WARNINGS in the CI workflow and the flake's clippy check. Local builds warn rather than fail. Because the lints now travel with the manifest instead of one alias, they apply to every cargo invocation, including the flake's clippy check, which previously ran with only clippy's defaults.

samuelburnham added 2 commits August 22, 2026 14:23

samuelburnham enabled auto-merge (squash) August 22, 2026 18:58

arthurpaulino approved these changes Aug 22, 2026
View reviewed changes