Constants Addition -- pi, newaxis, nan, inf

[AzeezIsh]

Addition to _constants.py to reflect Array API Standards. Amended __init.py as well accordingly.

Link reference below:
https://data-apis.org/array-api/2022.12/API_specification/constants.html#objects-in-api

[roaffix]

Is it a spec of 2022?

[AzeezIsh]

Is it a spec of 2022?

I believe so! The link I provided has "Python array API standard v2022.12" on the header -- https://data-apis.org/array-api/2022.12/API_specification/constants.html#objects-in-api

[roaffix]

We can pass at least black, isort, and flake8 checks. Please, fix the code style.
P.S. you can run locally make pre-commit

[AzeezIsh]

We can pass at least black, isort, and flake8 checks. Please, fix the code style. P.S. you can run locally make pre-commit

I just passed them all on the _constants file. Should be good!

[roaffix]

We can pass at least black, isort, and flake8 checks. Please, fix the code style. P.S. you can run locally make pre-commit

I just passed them all on the _constants file. Should be good!

but its not good :)

just run locally make pre-commit. We are good if all checks pass

[roaffix]

Quick hack: use black . and isort . These tools will fix the code style automatically, so you don't need to fix it manually

[AzeezIsh]

Quick hack: use black . and isort . These tools will fix the code style automatically, so you don't need to fix it manually

make command doesn't work. And i've also confirmed that running isort once again on the local file leads to no changes for _constants.py

_init.py has to be rebased hold on

[roaffix]

Quick hack: use black . and isort . These tools will fix the code style automatically, so you don't need to fix it manually

make command doesn't work. And i've also confirmed that running isort once again on the local file leads to no changes for _constants.py

You could open the failed check and look through the traceback

Your commit also affect other files, so the problem can occur not only in constants file

[AzeezIsh]

Quick hack: use black . and isort . These tools will fix the code style automatically, so you don't need to fix it manually

make command doesn't work. And i've also confirmed that running isort once again on the local file leads to no changes for _constants.py

You could open the failed check and look through the traceback

Your commit also affect other files, so the problem can occur not only in constants file

Hopefully it's good now! Mypy is failing in other places that I haven't touched

[roaffix]

what kind of issue with mypy?

[AzeezIsh]

what kind of issue with mypy?

Bunch of little weird errors, there's a high chance they were already there? It's not required though so the merge should be good

[roaffix]

what kind of issue with mypy?

Bunch of little weird errors, there's a high chance they were already there? It's not required though so the merge should be good

I run master locally and all is good. So, you should also not have any problems with your local machine. Paste a screen of errors here, so I can check if it's a common cross-platform or PR-related issue.

Also, all checks are required TBH, but due to WIP CI status - it is not available on GitHub actions.

[AzeezIsh]

what kind of issue with mypy?

Bunch of little weird errors, there's a high chance they were already there? It's not required though so the merge should be good

I run master locally and all is good. So, you should also not have any problems with your local machine. Paste a screen of errors here, so I can check if it's a common cross-platform or PR-related issue.

Also, all checks are required TBH, but due to WIP CI status - it is not available on GitHub actions.

(.venv) aishaqui@aishaqui-mobl:~/ArrayFire/arrayfire-py$ black .
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running pip install "black[jupyter]"
reformatted /home/aishaqui/ArrayFire/arrayfire-py/examples/common/idxio.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/random.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/blas.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/logistic_regression.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/data.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/device.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/examples/machine_learning/mnist_common.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/arith.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/examples/machine_learning/logistic_regression.py
reformatted /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/algorithm.py

All done! ✨ 🍰 ✨
10 files reformatted, 63 files left unchanged.
(.venv) aishaqui@aishaqui-mobl:~/ArrayFire/arrayfire-py$ isort .
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/logistic_regression.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/algorithm.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/random.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/device.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/arith.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/data.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/arrayfire/blas.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/examples/machine_learning/logistic_regression.py
Fixing /home/aishaqui/ArrayFire/arrayfire-py/examples/machine_learning/mnist_common.py
Skipped 4 files

(.venv) aishaqui@aishaqui-mobl:~/ArrayFire/arrayfire-py$ mypy .
build/lib/arrayfire/init.py: error: Duplicate module named "arrayfire" (also at "./arrayfire/init.py")
build/lib/arrayfire/init.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
build/lib/arrayfire/init.py: note: Common resolutions include: a) using --exclude to avoid checking one of them, b) adding __init__.py somewhere, c) using --explicit-package-bases or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)

[AzeezIsh]

what kind of issue with mypy?

Bunch of little weird errors, there's a high chance they were already there? It's not required though so the merge should be good

I run master locally and all is good. So, you should also not have any problems with your local machine. Paste a screen of errors here, so I can check if it's a common cross-platform or PR-related issue.

Also, all checks are required TBH, but due to WIP CI status - it is not available on GitHub actions.

Just bumping this as I'm working on an ArrayFire API example. My previous merge request also had the same issues with MyPy, so it might just be appearing specific to my local machine. Anything else I could do on my end?