Support commits from a linked worktree - #28
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the commit CLI to correctly support commits made from linked Git worktrees by using go-git’s common .git directory support, and adds an end-to-end test to cover committing from a linked worktree. It also includes minor whitespace cleanups and removes an unused constant.
Changes:
- Update repository opening and HEAD/branch detection to work in linked worktrees (
EnableDotGitCommonDir, useplumbing.HEADreference). - Add an e2e test that creates a linked worktree and commits from it.
- Clean up whitespace and remove an unused helper constant.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cmd/commit/main.go | Opens repos with support for common git dirs and derives branch name via go-git refs (worktree-compatible). |
e2e.sh | Adds a linked-worktree commit test and a helper for removing worktrees; whitespace normalization. |
internal/helpers/constants.go | Removes now-unused HEAD_REF_PREFIX constant. |
docs/README.md | Whitespace cleanup in JSON example (but reveals a JSON validity issue). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
In this PR: