Skip to content

Support commits from a linked worktree - #28

Merged
artem-y merged 5 commits into
mainfrom
feat/support-worktrees
Mar 23, 2026
Merged

Support commits from a linked worktree#28
artem-y merged 5 commits into
mainfrom
feat/support-worktrees

Conversation

@artem-y

Copy link
Copy Markdown
Owner

In this PR:

  • updated the tool to support making commits from linked worktree
  • added a test for a scenario when commit is being made from a linked worktree
  • cleaned up extra whitespaces

@artem-yartem-y self-assigned this Mar 22, 2026
@artem-yartem-y added the enhancement New feature or request label Mar 22, 2026
@artem-y
artem-y requested a review from CopilotMarch 23, 2026 06:21

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the commit CLI to correctly support commits made from linked Git worktrees by using go-git’s common .git directory support, and adds an end-to-end test to cover committing from a linked worktree. It also includes minor whitespace cleanups and removes an unused constant.

Changes:

  • Update repository opening and HEAD/branch detection to work in linked worktrees (EnableDotGitCommonDir, use plumbing.HEAD reference).
  • Add an e2e test that creates a linked worktree and commits from it.
  • Clean up whitespace and remove an unused helper constant.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

FileDescription
cmd/commit/main.goOpens repos with support for common git dirs and derives branch name via go-git refs (worktree-compatible).
e2e.shAdds a linked-worktree commit test and a helper for removing worktrees; whitespace normalization.
internal/helpers/constants.goRemoves now-unused HEAD_REF_PREFIX constant.
docs/README.mdWhitespace cleanup in JSON example (but reveals a JSON validity issue).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threade2e.sh Outdated
Comment threade2e.sh
Comment threade2e.sh
Comment threade2e.sh
@artem-y
artem-y merged commit 57b64da into mainMar 23, 2026
1 check passed
@artem-y
artem-y deleted the feat/support-worktrees branch March 24, 2026 14:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@artem-y