fix work tab

[arul28]

Summary by CodeRabbit

• New Features

  • Auto-closing CLI tool terminals when idle
  • Launch panel with quick-access buttons for terminals and chats
  • Session context menus with close, end, resume, and navigation actions
  • Detailed session information popovers displaying metadata and output
  • Session filtering by lane, status, and keywords
  • Tab/grid view toggle for managing sessions
  • Tool-type badges and logos for session identification

• UI/UX Improvements

  • Reorganized terminal interface with streamlined 2-pane layout
  • Enhanced session cards displaying status, runtime, and exit codes

[coderabbitai]

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 8bcc746 and dee88eb.

⛔ Files ignored due to path filters (3)

• assets/claude.svg is excluded by !**/*.svg
• assets/codex.svg is excluded by !**/*.svg
• assets/terminal.svg is excluded by !**/*.svg

📒 Files selected for processing (13)

• apps/desktop/src/main/services/pty/ptyService.ts
• apps/desktop/src/renderer/components/lanes/LaneTerminalsPanel.tsx
• apps/desktop/src/renderer/components/terminals/LaunchPanel.tsx
• apps/desktop/src/renderer/components/terminals/SessionCard.tsx
• apps/desktop/src/renderer/components/terminals/SessionContextMenu.tsx
• apps/desktop/src/renderer/components/terminals/SessionInfoPopover.tsx
• apps/desktop/src/renderer/components/terminals/SessionListPane.tsx
• apps/desktop/src/renderer/components/terminals/TerminalSettingsDialog.tsx
• apps/desktop/src/renderer/components/terminals/TerminalsPage.tsx
• apps/desktop/src/renderer/components/terminals/ToolLogos.tsx
• apps/desktop/src/renderer/components/terminals/WorkViewArea.tsx
• apps/desktop/src/renderer/components/terminals/useSessionDelta.ts
• apps/desktop/src/renderer/components/terminals/useWorkSessions.ts

---

📝 Walkthrough

Walkthrough

This pull request introduces comprehensive terminal session management enhancements. It adds auto-close functionality for tool-type PTYs with timestamp tracking in ptyService.ts, extracts terminal settings UI into a dedicated component, introduces multiple new UI components for session display and management (SessionCard, SessionContextMenu, SessionInfoPopover, SessionListPane, WorkViewArea, LaunchPanel, ToolLogos), refactors TerminalsPage with new work-session-centric state management via useWorkSessions hook, and adds useSessionDelta for session delta data fetching.

Changes

Cohort / File(s)	Summary
PTY Service Enhancement apps/desktop/src/main/services/pty/ptyService.ts	Added per-PTY creation timestamp (createdAt), implemented auto-close mechanism for tool-type PTYs with scheduled 1.5s delayed close on waiting-input state, timer management (clearToolAutoCloseTimer), and cleanup on PTY disposal/close.
Terminal Settings UI Refactoring apps/desktop/src/renderer/components/lanes/LaneTerminalsPanel.tsx, apps/desktop/src/renderer/components/terminals/TerminalSettingsDialog.tsx	Extracted terminal settings UI from LaneTerminalsPanel (removed 243 lines) into dedicated TerminalSettingsDialog component with profile management, color-coding, persistence, and launch-tracked state handling. Added readLaunchTracked/persistLaunchTracked helpers for localStorage integration.
New Terminal Session UI Components apps/desktop/src/renderer/components/terminals/SessionCard.tsx, apps/desktop/src/renderer/components/terminals/SessionContextMenu.tsx, apps/desktop/src/renderer/components/terminals/SessionInfoPopover.tsx, apps/desktop/src/renderer/components/terminals/ToolLogos.tsx	Introduced four new components for terminal session display and management: SessionCard renders individual session entries with status and actions; SessionContextMenu provides context-sensitive actions (close/end/resume); SessionInfoPopover displays detailed session metadata and stats; ToolLogos provides tool-specific SVG logo components and selection logic.
Terminal Launch & Session List Management apps/desktop/src/renderer/components/terminals/LaunchPanel.tsx, apps/desktop/src/renderer/components/terminals/SessionListPane.tsx	Added LaunchPanel for managing terminal lane selection and launching PTYs with profile-specific startup commands. Added SessionListPane to display filtered sessions in running/ended categories with lane/status filtering, search, and integration with LaunchPanel.
Terminal View & Session State Management apps/desktop/src/renderer/components/terminals/WorkViewArea.tsx, apps/desktop/src/renderer/components/terminals/useWorkSessions.ts, apps/desktop/src/renderer/components/terminals/useSessionDelta.ts	Introduced WorkViewArea component supporting both tab and grid view modes for session display. Added useWorkSessions hook managing session data, filtering (lane/status/search), tabs, selection, and lifecycle actions (launch/resume/close). Added useSessionDelta hook for fetching and caching session delta summary data.
Terminal Page Restructuring apps/desktop/src/renderer/components/terminals/TerminalsPage.tsx	Refactored page layout from multi-pane legacy structure to simplified 2-pane design using new work-sessions context. Replaced inline session management with SessionListPane and WorkViewArea components. Integrated floating overlays (SessionContextMenu, SessionInfoPopover) and reworked header actions to use work context (closeAllRunning, refresh). Updated tiling layout ID from v2 to v3.

Sequence Diagram(s)

sequenceDiagram
participant User as User
participant UI as Terminal UI
participant PTY as PTY Service
participant Timer as Auto-Close Timer
User->>UI: Launch terminal with tool profile
UI->>PTY: create(laneId, toolType, command)
PTY->>PTY: Record createdAt timestamp
PTY->>UI: Return PTY instance
loop While PTY Running
User->>PTY: Interact with terminal
PTY->>UI: Emit data/status events
UI->>UI: Update session state
end
User->>PTY: Exit or stop command
PTY->>PTY: Check: waiting-input state + tool type + age > 5s?
alt Tool Auto-Close Conditions Met
PTY->>Timer: Schedule 1.5s auto-close
PTY->>UI: Log info event
Timer->>Timer: Wait 1.5s
Timer->>PTY: Kill PTY
PTY->>UI: Session ended
else Manual Close Path
PTY->>UI: Session ended (manual/resumed)
end
PTY->>Timer: Clear timer on dispose

Loading

sequenceDiagram
participant User as User
participant Page as TerminalsPage
participant Hook as useWorkSessions
participant API as IPC/Backend API
participant Store as App Store
User->>Page: View terminals page
Page->>Hook: useWorkSessions()
Hook->>API: Fetch terminal sessions
API->>Hook: Return TerminalSessionSummary[]
Hook->>Store: Get lanes, selectedLaneId
Hook->>Hook: Apply filters (lane/status/search)
Hook->>Page: Return sessions, filters, actions
Page->>Page: Render SessionListPane + WorkViewArea
Page->>Page: Render SessionContextMenu overlay
Page->>Page: Render SessionInfoPopover overlay
User->>Page: Click launch PTY
Page->>Hook: onLaunchPty(laneId, profile)
Hook->>API: pty.create(laneId, toolType, command, tracked)
API->>API: Create PTY (with auto-close)
Hook->>Hook: Update session list, refresh
User->>Page: Select session context menu action
Page->>Hook: onCloseSession/onResume/onEndChat
Hook->>API: Execute action (closePty/resume/endChat)
Hook->>Hook: Refresh sessions
Page->>Page: Re-render with updated state

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}