Missions Tab Overhaul And Fixes by arul28 · Pull Request #257 · arul28/ADE

arul28 · 2026-05-08T03:59:03Z

Summary

Describe the change.

What Changed

Key files and behaviors.

Validation

How you tested.

Risks

Anything to watch.

Note

Medium Risk
Touches mission orchestration/RPC routing (resume, worker messaging, worker-state reporting) and introduces new headless RPC/MCP servers, which could affect run control and inter-agent communication if regressions occur.

Overview
Adds a typed missions command surface to ade-cli (create/launch/start/watch/graph/runs/pause/resume/cancel), including optional wait-for-run-graph polling to keep headless runtimes alive and richer text formatters for mission outputs.

Extends the CLI to run as a stdio MCP server via ade mcp, with tool-name normalization and optional scoping to coordinator tools; headless mode now also spins up local TCP + mirror socket RPC servers (with ADE_RPC_URL/ADE_RPC_SOCKET_PATH overrides) to support worker/tool callers.

Improves mission-runtime RPC behavior: routes resume_mission through aiOrchestratorService.resumeRun, exposes message_worker to agent callers with enforced worker ownership and a queued-for-polling fallback when live delivery fails, and expands get_worker_states to include persisted runWorkers derived from the run graph while filtering out non-worker/task/system steps.

On the desktop side, tightens embedding usage by gating hybrid search + embedding worker processing when there are active runs/sessions, and makes Codex task execution more robust by converting structured output schemas into stricter Codex-compatible JSON Schemas (with accompanying tests).

^{Reviewed by Cursor Bugbot for commit fe0b741. Configure here.}

Greptile Summary

This PR adds a typed missions CLI surface (create/list/launch/start/watch/graph/runs/pause/resume/cancel) with text formatters and a headless wait-run-graph polling loop, and introduces ade mcp mode that exposes ADE tools over stdio MCP with optional coordinator-only scoping.

Mission RPC overhaul: message_worker is exposed to agent callers with strict caller-context enforcement; when live delivery fails the message is queued to the DB poll path (only on failed delivery); resume_mission is rerouted through aiOrchestratorService.resumeRun so coordinator restart and resume-message injection occur correctly.
get_worker_states enriched: Response now includes a runWorkers array derived from the run graph via isRunWorkerStep filtering, correctly excluding planner, system-managed, and display-only task steps from peer discovery.
Worker spawn improvements: spawnWorkerStep now fuzzy-matches reusable task shells by name/token overlap, applies phase hints, propagates readOnly metadata, and threads retryLimit from delegation contracts into step creation and task-shell conversion.

Confidence Score: 4/5

Safe to merge with review of the intervention_required status handling in missionService and the run-view subscription resilience; the core RPC and MCP plumbing is sound.

The isRunWorkerStep filter, the conditional DB queue write in message_worker, and the rerouting of resume_mission through aiOrchestratorService.resumeRun are all correct. The riskier areas are the ACTIVE_MISSION_STATUSES change that drops intervention_required from the concurrency cap and the active dashboard query, and the removal of the periodic polling fallback in the run view — both are live behavioral changes affecting mission coordination and UI state during user-input pauses that deserve targeted validation.

apps/desktop/src/main/services/missions/missionService.ts (intervention_required concurrency and dashboard filtering), apps/desktop/src/renderer/components/missions/useMissionRunView.ts (subscription-only refresh with no safety fallback), apps/desktop/src/renderer/components/missions/MissionChatV2.tsx (load-older path is now dead code)

Important Files Changed

Filename	Overview
apps/ade-cli/src/cli.ts	Adds ~1400 lines covering missions CLI surface, MCP server mode, headless wait-run-graph polling loop, and worker mission tool passthrough; overall logic is sound but the 1-second polling interval in waitForRunGraph can produce up to 3600 requests per 30-minute wait window.
apps/ade-cli/src/adeRpcServer.ts	Exposes message_worker to agent callers with strict fromWorkerId enforcement; DB queue write correctly conditioned on failed live delivery; isRunWorkerStep filter properly excludes planner/system-managed/display-only steps from runWorkers; resume_mission rerouted to aiOrchestratorService.resumeRun for full coordinator restart semantics.
apps/desktop/src/main/services/orchestrator/coordinatorTools.ts	Adds fuzzy task-shell matching, phase-hint resolution, readOnly metadata, retryLimit propagation, and auto-spawned validation proof step exclusion from run completion checks; isTaskShellStep now correctly excludes plannerLaunchTracker and systemManaged steps.
apps/desktop/src/main/services/missions/missionService.ts	ACTIVE_MISSION_STATUSES now excludes intervention_required, affecting both the concurrency cap (missions awaiting user input don't count toward the limit) and the active dashboard query (they are post-filtered out of the live list).
apps/desktop/src/main/services/orchestrator/aiOrchestratorService.ts	Large additions covering resumeRun coordinator-restart flow, steering autopilot start, and auto-resume guard checking run status before resuming; changes are well-structured with appropriate error handling.
apps/desktop/src/main/services/orchestrator/workerDeliveryService.ts	Adds shouldPreferSteerForWorkerSession to route Codex provider messages through steer instead of direct send, avoiding rejection on concurrent turns; clean implementation.
apps/desktop/src/renderer/components/chat/missionControlTextTools.ts	New file parsing mission control tool calls from free-text agent output using fenced code blocks and comment-label fallback; findBalancedJson handles standard string escapes correctly.
apps/desktop/src/main/services/orchestrator/executionPolicy.ts	Improves phase resolution (phaseKey/phaseName priority over stepType), excludes auto-spawned validation proof steps from required-validation checks, widens phaseKeyToExecutionPhase to handle prefixed/suffixed keys, and uses resolveModelDescriptor for better model lookup.
apps/desktop/src/renderer/components/missions/useMissionRunView.ts	Removes the periodic polling fallback; run view now refreshes only on mount and subscription events, leaving no recovery path if the IPC subscription stalls mid-run.
apps/desktop/src/renderer/components/missions/MissionChatV2.tsx	Removes loadOlderSelectedMessages and the threadMessagesHasMore/threadMessagesLoadingMore state; the append-older branch in refreshThreadMessages is now dead code, making messages beyond THREAD_MESSAGE_PAGE_SIZE permanently inaccessible.

Sequence Diagram

sequenceDiagram
participant CLI as ade CLI
participant ADE as ADE RPC Server
participant ORC as aiOrchestratorService
participant DB as DB / KV Store
participant AGENT as Worker Agent
Note over CLI,AGENT: missions launch --wait-ms 30000
CLI->>ADE: "mission.create (autostart=false)"
ADE->>DB: INSERT mission
CLI->>ADE: orchestrator.startMissionRun
ADE->>ORC: ensureCoordinatorAgentV2
ORC-->>AGENT: start coordinator
CLI->>ADE: ade-cli/wait-run-graph (poll 1s)
loop until terminal or deadline
CLI->>ADE: orchestrator_core.getRunGraph
ADE-->>CLI: "{run.status, steps, attempts}"
end
CLI-->>CLI: format mission-watch output
Note over CLI,AGENT: resume_mission RPC tool
AGENT->>ADE: "resume_mission {runId}"
ADE->>ORC: aiOrchestratorService.resumeRun
ORC->>ORC: ensureCoordinatorAgentV2
ORC->>AGENT: injectMessage [RUN RESUMED]
ORC-->>ADE: OrchestratorRun
Note over AGENT,DB: message_worker (agent caller)
AGENT->>ADE: "message_worker {toWorkerId, content}"
ADE->>ADE: normalizeAgentDelegationToolArgs (enforce fromWorkerId)
ADE->>ORC: coordinatorTool.execute
alt live delivery succeeds
ORC-->>AGENT: "{delivered:true, queuedForPolling:false}"
else live delivery fails
ADE->>DB: maybeSendInterAgentMessage (polling queue)
ADE-->>AGENT: "{delivered:false, queuedForPolling:true}"
end
Note over CLI,DB: ade mcp (stdio MCP server)
CLI->>CLI: runMcpServer (headless)
CLI->>CLI: startJsonRpcServer over stdin/stdout
loop MCP requests
CLI->>ADE: ade/actions/call (scoped by ADE_MCP_TOOL_SCOPE)
ADE-->>CLI: result
CLI-->>CLI: MCP tools/call response
end

_{Reviews (6): Last reviewed commit: "fix: address headless drain review" | Re-trigger Greptile}

Summary by CodeRabbit

New Features
- Mission orchestration with new integration and closeout phases
- Mission management commands (create, launch, show, runs, graph, watch, pause, resume, cancel)
- MCP server mode for ADE CLI
- Codex reasoning effort configuration and persistence
- OpenCode integration with ADE MCP support
- Improved worker messaging and delegation handling
Bug Fixes
- Better git error reporting for missing working directories
- Improved run completion validation and phase transition logic
- Fixed embedding worker deferral during sensitive activity
- Enhanced worker startup and lifecycle management
Improvements
- Phase sequence validation with predecessor/successor ordering enforcement
- Stricter validation gating and completion requirements
- Better sensitive activity detection to defer embeddings
- Improved chat persistence and replay for missions
- More robust orchestrator recovery and health monitoring

vercel · 2026-05-08T03:59:07Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ade	Ignored	Preview	May 8, 2026 5:27am

coderabbitai · 2026-05-08T03:59:10Z

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Adds mission CLI/MCP mode, run-graph waiting, coordinator message queueing, resume via AI orchestrator, expanded phase/validation policy, coordinator tools updates, IPC compaction/redaction, embedding gating/defer, logging refactor, lane linking, OpenCode ADE MCP config, Codex schema strictification, and tests.

Changes

End-to-end mission and runtime orchestration

Layer / File(s)	Summary
All changes `apps//`	Contracts/policies, orchestrator/coordinator tools/services, CLI/MCP and RPC handlers, desktop IPC/memory/logging/git/lanes/OpenCode/provider schema, and tests consolidated for review.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

arul28/ADE#144 — Switches resume routing to AI orchestrator and related coordinator resume behavior.
arul28/ADE#219 — Overlaps desktop services (IPC, embedding) touched here.
arul28/ADE#190 — Modifies agentChatService; relates to reasoning effort and mission-surface handling.

Suggested labels

desktop

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ade/missions-tab-overhaul-and-fixes-ece96cdb

arul28 · 2026-05-08T03:59:13Z

@copilot review but do not make fixes

arul28 · 2026-05-08T03:59:13Z

@cursor review

cursor · 2026-05-08T03:59:15Z

Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings.

capy-ai · 2026-05-08T03:59:30Z

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

Copilot · 2026-05-08T04:00:12Z

@copilot review but do not make fixes

Reviewed the current PR changes through commit b145f74 and did not apply any fixes, per your request. I don’t see any additional blocking issues from this pass.

arul28 · 2026-05-08T04:17:28Z

@copilot review but do not make fixes

arul28 · 2026-05-08T04:17:28Z

@cursor review

cursor · 2026-05-08T04:17:30Z

Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings.

Copilot · 2026-05-08T04:19:01Z

@copilot review but do not make fixes

Reviewed the branch through commit 077eb53 and kept this pass review-only (no fixes applied). I don’t see additional blocking issues from this pass.

arul28 · 2026-05-08T04:20:18Z

@cursor review

arul28 · 2026-05-08T04:20:19Z

@copilot review but do not make fixes

cursor · 2026-05-08T04:20:21Z

Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings.

Copilot · 2026-05-08T04:21:27Z

@copilot review but do not make fixes

Reviewed the branch through commit 1070291 and kept this pass review-only (no fixes applied). I don’t see additional blocking issues from this pass.

arul28 · 2026-05-08T04:28:31Z

@cursor review

arul28 · 2026-05-08T04:28:31Z

@copilot review but do not make fixes

Copilot · 2026-05-08T04:30:08Z

@copilot review but do not make fixes

Reviewed the branch through commit 01b40f2 and kept this pass review-only (no fixes applied). I don’t see additional code-level blockers from this pass; current runs for 01b40f2 are still in progress, and the prior 1070291 CI failure was in missionService.test.ts (stale lane-claim FK setup).

arul28 · 2026-05-08T05:19:34Z

@copilot review but do not make fixes

arul28 · 2026-05-08T05:19:34Z

@cursor review

cursor · 2026-05-08T05:24:58Z

+ method: "ade-cli/sleep",
+ params: { ms: Math.min(30 * 60 * 1000, Math.max(0, Math.floor(ms))) },
+ };
+}


Dead code: sleepStep defined but never called
Low Severity
sleepStep creates an InvocationStep with method: "ade-cli/sleep" and a runtime handler exists for that method (line 6595), but no call site in buildMissionsPlan or any other plan builder ever invokes sleepStep. If a deliberate pause between plan steps was intended (e.g., before polling after launch), the delay is silently skipped.
^{Reviewed by Cursor Bugbot for commit 918a4cd. Configure here.}

arul28 · 2026-05-08T05:27:58Z

@copilot review but do not make fixes

arul28 · 2026-05-08T05:27:58Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit fe0b741. Configure here.}

Copilotstarted work on behalf of arul28 May 8, 2026 03:59 View session

Copilotfinished work on behalf of arul28 May 8, 2026 04:00

greptile-appsBot reviewed May 8, 2026
View reviewed changes

Copilotstarted work on behalf of arul28 May 8, 2026 04:17 View session

Copilotfinished work on behalf of arul28 May 8, 2026 04:19

arul28 force-pushed the ade/missions-tab-overhaul-and-fixes-ece96cdb branch from 077eb53 to 1070291Compare May 8, 2026 04:20

Copilotstarted work on behalf of arul28 May 8, 2026 04:20 View session

Copilotfinished work on behalf of arul28 May 8, 2026 04:21

greptile-appsBot reviewed May 8, 2026
View reviewed changes

Comment threadapps/desktop/src/renderer/components/missions/MissionChatV2.tsx

Copilotstarted work on behalf of arul28 May 8, 2026 04:28 View session

Copilotfinished work on behalf of arul28 May 8, 2026 04:30

cursorBot reviewed May 8, 2026
View reviewed changes

Comment threadapps/ade-cli/src/cli.ts
Comment threadapps/desktop/src/renderer/components/missions/missionHelpers.ts Outdated

Copilotstarted work on behalf of arul28 May 8, 2026 05:07 View session

cursorBot reviewed May 8, 2026
View reviewed changes

Comment threadapps/ade-cli/src/adeRpcServer.ts
Comment threadapps/ade-cli/src/cli.ts

greptile-appsBot reviewed May 8, 2026
View reviewed changes

Comment threadapps/ade-cli/src/adeRpcServer.ts

arul28 added 9 commits May 8, 2026 01:17

ship: checkpoint before automate/finalize
981907f

ship: finalize lane for review
3dbd3d7

fix: address missions review feedback
3e1aac9

test: simulate stale mission lane claim
c24cdf4

fix: address chat pagination and socket review
624c941

fix: address CLI cancel review
a39920c

fix: await mission resume RPC
fe98015

fix: address worker state and graph wait review
38c9989

fix: address message worker queue review
918a4cd

arul28 force-pushed the ade/missions-tab-overhaul-and-fixes-ece96cdb branch from 0f8f8c4 to 918a4cdCompare May 8, 2026 05:19

Copilotstarted work on behalf of arul28 May 8, 2026 05:19 View session

cursorBot reviewed May 8, 2026
View reviewed changes

fix: address headless drain review
fe0b741

Copilotstarted work on behalf of arul28 May 8, 2026 05:28 View session

cursorBot reviewed May 8, 2026
View reviewed changes

arul28 merged commit a14ffcb into mainMay 8, 2026
24 of 26 checks passed

arul28 deleted the ade/missions-tab-overhaul-and-fixes-ece96cdb branch May 8, 2026 23:33

coderabbitaiBot mentioned this pull request May 21, 2026
Deeplinks #326
Merged

coderabbitaiBot mentioned this pull request Aug 6, 2026
Start Skill Am Gonna List -> Primary #1049
Merged

Conversation

arul28 commented May 8, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Validation

Risks

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Summary by CodeRabbit

Uh oh!

vercelBot commented May 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitaiBot commented May 8, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

cursorBot commented May 8, 2026

Uh oh!

capy-aiBot commented May 8, 2026

Uh oh!

CopilotAI commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

cursorBot commented May 8, 2026

Uh oh!

CopilotAI commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

cursorBot commented May 8, 2026

Uh oh!

CopilotAI commented May 8, 2026

Uh oh!

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

CopilotAI commented May 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

Uh oh!

cursorBotMay 8, 2026

Choose a reason for hiding this comment

Dead code: sleepStep defined but never called

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026

Uh oh!

arul28 commented May 8, 2026•
edited by coderabbitai Bot
Loading

vercelBot commented May 8, 2026•
edited
Loading

coderabbitaiBot commented May 8, 2026•
edited
Loading