Fix iOS sync deeplinks opening in wrong project window - #350
Closed
cursor[bot] wants to merge 2 commits into
Closed
Conversation
When iOS sends ade:// links via sync deeplinks.open, the handler used the global focused-window dispatcher. With multiple projects open, navigation landed in the wrong window (missing lane/PR targets). Route sync deeplinks through project-scoped window lookup (same path as appNavigationService.navigate) and add a regression test for the dispatch contract. Co-authored-by: Arul Sharma <arul28@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Co-authored-by: Arul Sharma <arul28@users.noreply.github.com>
This was referenced May 24, 2026
arul28
commented
May 25, 2026
Owner
Consolidated into #356. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When iOS sends an
ade://link via thedeeplinks.opensync command ("Send to your Mac"), desktop routed navigation through the global focused-window dispatcher. With multiple projects open, the deeplink could land in the wrong window—lane/PR/branch targets from project B would be applied in project A's renderer, causing broken navigation and user confusion.Root cause
dispatchDeeplinkUrlin the per-project sync service calledhandleDeeplinkUrl(..., dispatchOrQueueAppNavigationRequest), which usesBrowserWindow.getFocusedWindow()instead of the sync host'sprojectRoot. A project-scoped navigation path already existed onappNavigationService.navigatebut was not used for iOS sync.Fix
deliverAppNavigationToProject/dispatchAppNavigationForProjectRoothelpers (same window lookup as RPCappNavigationService).sync:iosdeeplinks through project-scoped dispatch; fall back to global dispatch only if helpers are not yet initialized.appNavigationService.navigateto use the shared helper.Validation
npm --prefix apps/desktop run test -- --run src/main/services/deeplinks/projectNavigationDispatch.test.ts(2 passed)Related open PRs (not duplicated)