Fix iOS chat keyboard dismissal by arul28 · Pull Request #787 · arul28/ADE

arul28 · 2026-07-11T01:23:16Z

Summary

dismiss the iOS keyboard and collapse the composer immediately after sending from every mobile chat surface
keep the Work new-chat activity carousel in scroll content so keyboard-driven composer growth no longer pushes it upward
document the mobile composer behavior

Validation

quality: clean after one synthesis/re-review pass
xcodebuild test -only-testing:ADETests/WorkComposerTriggerDetectorTests (18 tests passed)
node scripts/validate-docs.mjs

Summary by CodeRabbit

Bug Fixes
- Composers now collapse and dismiss keyboard focus immediately when sending messages or creating chats.
- Improved synchronization of text-field focus transitions to prevent inconsistent composer states.
- Moved the usage activity carousel into the chat’s scrollable content for a more consistent layout.
Tests
- Added coverage for clearing drafts, dismissing focus, and applying composer focus transitions.

Greptile Summary

This PR updates mobile chat composer behavior on iOS. The main changes are:

Chat composers dismiss keyboard focus after send or create actions.
Work chat draft state now tracks focus requests for its text view bridge.
Failed Work chat sends restore unsent text and attachments.
The Work new-chat usage carousel now lives inside the scroll content.
Tests and docs cover the new composer focus behavior.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

No files need attention.

T-Rex Logs

What T-Rex did

The environment was checked for iOS tooling, and xcodebuild, xcrun, and swift were all unavailable.
ADETests command execution is blocked by the missing native iOS tooling, as recorded in the work-composer log.
Docs validation completed successfully with exit code 0.

_{Ran code and verified through T-Rex}

Important Files Changed

Filename	Overview
apps/ios/ADE/Views/Hub/HubComposerDrawer.swift	Hub inline composer now collapses before clearing sent draft content.
apps/ios/ADE/Views/PersonalChats/PersonalChatsScreen.swift	Personal new-chat creation now clears composer focus before starting work.
apps/ios/ADE/Views/Work/WorkChatSessionView.swift	Work chat draft state now coordinates text clearing, restore behavior, and focus requests.
apps/ios/ADE/Views/Work/WorkComposerTypedTriggers.swift	Work composer text view now applies requested focus changes and reports editing state.
apps/ios/ADE/Views/Work/WorkNewChatScreen.swift	Work new-chat layout now keeps the activity carousel in scroll content and clears composer focus on send.
apps/ios/ADETests/WorkComposerTriggerDetectorTests.swift	Tests now cover draft focus state and requested focus transitions.
docs/features/sync-and-multi-device/ios-companion.md	Docs now describe mobile composer keyboard dismissal and carousel placement.

_{Reviews (2): Last reviewed commit: "ship: iteration 1 — restore focus after ..." | Re-trigger Greptile}

vercel · 2026-07-11T01:23:18Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
ade	Ignored	Preview	Jul 11, 2026 1:39am

arul28 · 2026-07-11T01:23:31Z

@copilot review but do not make fixes

coderabbitai · 2026-07-11T01:23:39Z

📝 Walkthrough

Walkthrough

Changes

iOS composer updates

Layer / File(s)	Summary
Work composer focus synchronization `apps/ios/ADE/Views/Work/WorkChatSessionView.swift`, `apps/ios/ADE/Views/Work/WorkComposerTypedTriggers.swift`, `apps/ios/ADETests/WorkComposerTriggerDetectorTests.swift`	Work chat draft state now owns focus state, synchronizes UIKit first-responder transitions, and validates focus changes and send-time clearing.
Send-time focus and collapse behavior `apps/ios/ADE/Views/Hub/HubComposerDrawer.swift`, `apps/ios/ADE/Views/PersonalChats/PersonalChatsScreen.swift`, `apps/ios/ADE/Views/Work/WorkNewChatScreen.swift`	Composer focus is dismissed or the composer is collapsed before chat submission begins.
Usage carousel placement `apps/ios/ADE/Views/Work/WorkNewChatScreen.swift`	The usage activity carousel now appears inside the main scroll view after the session action chips.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

arul28/ADE#703: Shares the Work chat composer and draft-state implementation.

Suggested labels:ios, docs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: improving iOS chat dismissal behavior when sending messages.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ade/start-skill-change-concerns-only-96d975f3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ios/ADE/Views/Work/WorkChatSessionView.swift`:
- Around line 2075-2080: Restore composer focus when an attempted send fails:
update the failure branch or the restoreUnsentText(_:) method to set
draftState.isFocused to true after restoring the unsent text and attachments, so
the keyboard and composer are immediately available for editing or resend.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2a46e07-3bc4-4c66-b853-cdc9e0ac2385

📥 Commits

Reviewing files that changed from the base of the PR and between 70c6e4e and 152e858.

⛔ Files ignored due to path filters (1)

docs/features/sync-and-multi-device/ios-companion.md is excluded by !docs/**

📒 Files selected for processing (6)

apps/ios/ADE/Views/Hub/HubComposerDrawer.swift
apps/ios/ADE/Views/PersonalChats/PersonalChatsScreen.swift
apps/ios/ADE/Views/Work/WorkChatSessionView.swift
apps/ios/ADE/Views/Work/WorkComposerTypedTriggers.swift
apps/ios/ADE/Views/Work/WorkNewChatScreen.swift
apps/ios/ADETests/WorkComposerTriggerDetectorTests.swift

arul28 · 2026-07-11T01:39:29Z

@codex review

chatgpt-codex-connector · 2026-07-11T01:43:12Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit:0d2f49a6d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

fix(ios): collapse chat composer after send
152e858

arul28 changed the title ~~mobile-chat-keyboard-dismissal -> Primary~~Fix iOS chat keyboard dismissalJul 11, 2026

coderabbitaiBot reviewed Jul 11, 2026
View reviewed changes

Comment threadapps/ios/ADE/Views/Work/WorkChatSessionView.swift

ship: iteration 1 — restore focus after failed send
0d2f49a

arul28 added the ready-to-merge label Jul 11, 2026

arul28 merged commit 8d61369 into mainJul 11, 2026
5 checks passed

arul28 deleted the ade/start-skill-change-concerns-only-96d975f3 branch July 11, 2026 03:11

coderabbitaiBot mentioned this pull request Jul 27, 2026
Fix mobile question cards: dropped chat events, card overflow, drafts, keyboard #907
Merged

Navigation Menu

Fix iOS chat keyboard dismissal - #787

Fix iOS chat keyboard dismissal#787
arul28 merged 2 commits into
mainfrom
ade/start-skill-change-concerns-only-96d975f3

arul28 commented Jul 11, 2026•
edited by greptile-apps Bot
Loading

Uh oh!

vercelBot commented Jul 11, 2026•
edited
Loading

Uh oh!

arul28 commented Jul 11, 2026

Uh oh!

coderabbitaiBot commented Jul 11, 2026•
edited
Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

arul28 commented Jul 11, 2026

Uh oh!

chatgpt-codex-connectorBot commented Jul 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

arul28 commented Jul 11, 2026• edited by greptile-apps BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Greptile Summary

Confidence Score: 5/5

T-Rex Logs

Important Files Changed

Uh oh!

vercelBot commented Jul 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arul28 commented Jul 11, 2026

Uh oh!

coderabbitaiBot commented Jul 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arul28 commented Jul 11, 2026

Uh oh!

chatgpt-codex-connectorBot commented Jul 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

arul28 commented Jul 11, 2026•
edited by greptile-apps Bot
Loading

vercelBot commented Jul 11, 2026•
edited
Loading

coderabbitaiBot commented Jul 11, 2026•
edited
Loading