Skip to content

Avoid leaking POSIX name aliases beyond subprocess.hpp - #112

Merged
arun11299 merged 1 commit into
arun11299:masterfrom
hebasto:250423-posix-names
Apr 24, 2025
Merged

Avoid leaking POSIX name aliases beyond subprocess.hpp#112
arun11299 merged 1 commit into
arun11299:masterfrom
hebasto:250423-posix-names

Conversation

@hebasto

@hebastohebasto commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

The commit a32c0f3 (#91) introduced code to silence MSVC's "warning C4996: The POSIX name for this item is deprecated."

However, it exhibits several issues:

  1. The aliases may leak into code outside the subprocess.hpp header.
  2. They are unnecessarily applied when using the MinGW-w64 toolchain.
  3. The fix is incomplete: downstream projects still see C4996 warnings:
D:\a\cpp-subprocess\cpp-subprocess\subprocess.hpp(517,21): warning C4996: 'write': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _write. See online help for details. [D:\a\cpp-subprocess\cpp-subprocess\build\test\test_cat.vcxproj]
  1. The implementation lacks documentation.

This PR addresses all of the above shortcomings.

Based on bitcoin/bitcoin@f9e5018.

@hebasto@luke-jr
Avoid leaking POSIX name aliases beyond subprocess.hpp
8a6c3cd
The commit a32c0f3 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
@hebastohebasto mentioned this pull request Apr 23, 2025
Merged
@arunmu-nx

arunmu-nx commented Apr 24, 2025

Copy link
Copy Markdown

Thanks for your contributions.

@arun11299
arun11299 merged commit 778543b into arun11299:masterApr 24, 2025
@hebasto
hebasto deleted the 250423-posix-names branch April 24, 2025 16:31
hebasto added a commit to hebasto/bitcoin that referenced this pull request Apr 27, 2025
@hebasto
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
c842a40
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
hebasto added a commit to hebasto/bitcoin that referenced this pull request Apr 27, 2025
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
df7a522
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
@fanquakefanquake mentioned this pull request Apr 29, 2025
Open
@hebastohebasto mentioned this pull request Apr 30, 2025
Merged
hebasto added a commit to hebasto/bitcoin that referenced this pull request May 1, 2025
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
174bd43
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
hebasto added a commit to bitcoin/bitcoin that referenced this pull request May 5, 2025
@hebasto
Merge#32358: subprocess: Backport upstream changes
53ccb75
cd95c9d subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)
b7288de subprocess: Proper implementation of wait() on Windows (Haowen Liu)
7423214 subprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)
bb9ffea subprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)
174bd43 subprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)
7997b76 subprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)
6476304 subprocess: Get Windows return code in wait() (Haowen Liu)
d3f511b subprocess: Fix string_arg when used with rref (Haowen Liu)
2fd3f2f subprocess: Fix memory leaks (Haoran Peng)
Pull request description:
Most of these changes were developed during work on #29868 and #32342 and have since been upstreamed.
As they are now merged, this PR backports them to our `src/util/subprocess.h` header.
Required for #29868.
A list of the backported PRs:
- arun11299/cpp-subprocess#106
- arun11299/cpp-subprocess#110
- arun11299/cpp-subprocess#109
- arun11299/cpp-subprocess#99
- arun11299/cpp-subprocess#112
- arun11299/cpp-subprocess#107
- arun11299/cpp-subprocess#113
- arun11299/cpp-subprocess#116
- arun11299/cpp-subprocess#117
The following PRs were skipped for backporting:
- arun11299/cpp-subprocess#108 because we are not planning to support this feature.
- arun11299/cpp-subprocess#101 because that change has been already landed in #29849.
ACKs for top commit:
theStack:
Light ACK cd95c9d
laanwj:
Code review re-ACK cd95c9d
Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
alexanderwiederin pushed a commit to alexanderwiederin/bitcoin that referenced this pull request May 8, 2025
@hebasto@luke-jr@alexanderwiederin
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
a618482
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Jun 6, 2025
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
4789fb3
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
Github-Pull: bitcoin#32358
Rebased-From: 174bd43
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Sep 7, 2025
@hebasto@luke-jr@janus
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
092c44a
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Jun 28, 2026
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
8e5bb08
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Jun 28, 2026
@hebasto
Mergebitcoin/bitcoin#32358: subprocess: Backport upstream changes
f221278
b5f498d subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)
2117d6e subprocess: Proper implementation of wait() on Windows (Haowen Liu)
d281ca6 subprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)
a322a8b subprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)
8e5bb08 subprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)
37421cd subprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)
f2006c7 subprocess: Get Windows return code in wait() (Haowen Liu)
7630b96 subprocess: Fix string_arg when used with rref (Haowen Liu)
ff0df49 subprocess: Fix memory leaks (Haoran Peng)
Pull request description:
Most of these changes were developed during work on bitcoin/bitcoin#29868 and bitcoin/bitcoin#32342 and have since been upstreamed.
As they are now merged, this PR backports them to our `src/util/subprocess.h` header.
Required for bitcoin/bitcoin#29868.
A list of the backported PRs:
- arun11299/cpp-subprocess#106
- arun11299/cpp-subprocess#110
- arun11299/cpp-subprocess#109
- arun11299/cpp-subprocess#99
- arun11299/cpp-subprocess#112
- arun11299/cpp-subprocess#107
- arun11299/cpp-subprocess#113
- arun11299/cpp-subprocess#116
- arun11299/cpp-subprocess#117
The following PRs were skipped for backporting:
- arun11299/cpp-subprocess#108 because we are not planning to support this feature.
- arun11299/cpp-subprocess#101 because that change has been already landed in bitcoin/bitcoin#29849.
ACKs for top commit:
theStack:
Light ACK b5f498d
laanwj:
Code review re-ACK b5f498d
Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
BigcoinBGC pushed a commit to BigcoinBGC/bigcoin that referenced this pull request Jun 30, 2026
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
a8f4858
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
BigcoinBGC pushed a commit to BigcoinBGC/bigcoin that referenced this pull request Jun 30, 2026
@hebasto
Mergebitcoin/bitcoin#32358: subprocess: Backport upstream changes
5718b2b
3a0f4d0 subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)
5ec84fb subprocess: Proper implementation of wait() on Windows (Haowen Liu)
a31139a subprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)
c006067 subprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)
a8f4858 subprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)
c1c6401 subprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)
c5478f3 subprocess: Get Windows return code in wait() (Haowen Liu)
fee2782 subprocess: Fix string_arg when used with rref (Haowen Liu)
b5de4db subprocess: Fix memory leaks (Haoran Peng)
Pull request description:
Most of these changes were developed during work on bitcoin/bitcoin#29868 and bitcoin/bitcoin#32342 and have since been upstreamed.
As they are now merged, this PR backports them to our `src/util/subprocess.h` header.
Required for bitcoin/bitcoin#29868.
A list of the backported PRs:
- arun11299/cpp-subprocess#106
- arun11299/cpp-subprocess#110
- arun11299/cpp-subprocess#109
- arun11299/cpp-subprocess#99
- arun11299/cpp-subprocess#112
- arun11299/cpp-subprocess#107
- arun11299/cpp-subprocess#113
- arun11299/cpp-subprocess#116
- arun11299/cpp-subprocess#117
The following PRs were skipped for backporting:
- arun11299/cpp-subprocess#108 because we are not planning to support this feature.
- arun11299/cpp-subprocess#101 because that change has been already landed in bitcoin/bitcoin#29849.
ACKs for top commit:
theStack:
Light ACK 3a0f4d0
laanwj:
Code review re-ACK 3a0f4d0
Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Aug 19, 2026
@hebasto@luke-jr
subprocess: Avoid leaking POSIX name aliases beyond subprocess.h
59acda1
The commit a32c0f3df4b6bcd1d2e93f19e8f380bb890cd507 introduced code to
silence MSVC's "warning C4996: The POSIX name for this item is
deprecated."
However, it exhibits several issues:
1. The aliases may leak into code outside the `subprocess.hpp` header.
2. They are unnecessarily applied when using the MinGW-w64 toolchain.
3. The fix is incomplete: downstream projects still see C4996 warnings.
4. The implementation lacks documentation.
This change addresses all of the above shortcomings.
Github-Pull: arun11299/cpp-subprocess#112
Rebased-From: 778543b2f2ca7f5d1c4f0241b635bbb265d750dd
Co-authored-by: Luke Dashjr <luke-jr+git@utopios.org>
Kino1994 pushed a commit to Kino1994/bitcoin-full-history that referenced this pull request Aug 19, 2026
@hebasto
Mergebitcoin/bitcoin#32358: subprocess: Backport upstream changes
1902ea9
cd95c9d6a7ec08cca0f9c98328c759be586720f8 subprocess: check and handle fcntl(F_GETFD) failure (Tomás Andróil)
b7288decdf534391b3f917cfb11ec62580407c3f subprocess: Proper implementation of wait() on Windows (Haowen Liu)
7423214d8deebbbcdab66090e185129decfaa799 subprocess: Do not escape double quotes for command line arguments on Windows (Hennadii Stepanov)
bb9ffea53fb021580f069c431aee02f547039831 subprocess: Explicitly define move constructor of Streams class (Shunsuke Shimizu)
174bd43f2e46a0ccc6f5ad486bb587c72c1241c3 subprocess: Avoid leaking POSIX name aliases beyond `subprocess.h` (Hennadii Stepanov)
7997b7656f99c5415cfa02cb1206226d0a82efd6 subprocess: Fix cross-compiling with mingw toolchain (Hennadii Stepanov)
647630462f10cacc7a75da7c82ca7c6d33bbde4b subprocess: Get Windows return code in wait() (Haowen Liu)
d3f511b4583b3771bf941ebc7884477430115039 subprocess: Fix string_arg when used with rref (Haowen Liu)
2fd3f2fec67a3bb62378c286fbf9667e6fb3cc3b subprocess: Fix memory leaks (Haoran Peng)
Pull request description:
Most of these changes were developed during work on bitcoin/bitcoin#29868 and bitcoin/bitcoin#32342 and have since been upstreamed.
As they are now merged, this PR backports them to our `src/util/subprocess.h` header.
Required for bitcoin/bitcoin#29868.
A list of the backported PRs:
- arun11299/cpp-subprocess#106
- arun11299/cpp-subprocess#110
- arun11299/cpp-subprocess#109
- arun11299/cpp-subprocess#99
- arun11299/cpp-subprocess#112
- arun11299/cpp-subprocess#107
- arun11299/cpp-subprocess#113
- arun11299/cpp-subprocess#116
- arun11299/cpp-subprocess#117
The following PRs were skipped for backporting:
- arun11299/cpp-subprocess#108 because we are not planning to support this feature.
- arun11299/cpp-subprocess#101 because that change has been already landed in bitcoin/bitcoin#29849.
ACKs for top commit:
theStack:
Light ACK cd95c9d6a7ec08cca0f9c98328c759be586720f8
laanwj:
Code review re-ACK cd95c9d6a7ec08cca0f9c98328c759be586720f8
Tree-SHA512: f9b60b932957d2e1cad1d87f2ad8bb68c97136e9735eb78547018a42cc50c4652750367f29462eadb0512c27db1dd8a7d4b17a2f0aeab62b3dbf86db5f51a61c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@arunmu-nxarunmu-nxarunmu-nx approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hebasto@arunmu-nx@arun11299