Uh oh!
There was an error while loading. Please reload this page.
SKYW-2246 Atualiza versão java-nfe para 4.1.1 - #43
Conversation
…macoes complementares
# Conflicts: # schemas/leiauteNFe_v4.00.xsd # schemas/nfe_v4.00.xsd
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Review Summary
This PR updates the java-nfe library from version 4.00.51 to 4.1.1, primarily to fix certificate-related errors identified in production. The PR includes a major JAXB refactoring, dependency updates, and build improvements.
Critical Security Issue
One critical security vulnerability was identified: a hardcoded Coveralls repository token in pom.xml that should be moved to environment variables.
Key Changes Verified
- ✅ Version bump to 4.1.1 correctly applied
- ✅ java-certificado dependency updated to 3.16 (contains certificate fixes)
- ✅ JaCoCo and test configuration improvements
- ✅ Comprehensive CHANGELOG.md and MIGRATION.md documentation provided
- ✅ Migration scripts included for consuming projects
Recommendations
Address the security issue before merging to production. The rest of the changes appear to be a well-documented library version update with proper migration support.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Descrição
Este PR sincroniza a biblioteca java-nfe para a versão 4.1.1.
Como essa versão traz mudanças que quebram a compatibilidade, foi necessário rodar scripts de migração para corrigir:
Imports desatualizados;
Nomes de classes que foram alterados.
🔗 Para conferir todos os detalhes do impacto, acesse o MIGRATION.md da biblioteca.
PR Relacionadas
Link da tarefa no JIRA
https://asaasdev.atlassian.net/jira/software/c/projects/SKYW/boards/413
Serviços afetados
service-nfe-api
Prints do desenvolvimento
Revisado Local pela IA