Skip to content

CTORM cumulus load tester - #69

Merged
benbart merged 8 commits into
CTORMfrom
bbarton/PR-7456
Jun 18, 2026
Merged

CTORM cumulus load tester#69
benbart merged 8 commits into
CTORMfrom
bbarton/PR-7456

Conversation

@benbart

@benbartbenbart commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@benbart
benbart changed the base branch from main to CTORMJune 12, 2026 02:09
gjclark
gjclark reviewed Jun 12, 2026
View reviewed changes
Comment threadctorm/infra/README.md Outdated
gjclark
gjclark reviewed Jun 12, 2026
View reviewed changes
Comment threadctorm/infra/terraform/dev.tfvars
@benbart
benbartforce-pushed the bbarton/PR-7456 branch 5 times, most recently from 9fe9481 to 617537cCompareJune 13, 2026 00:42
@benbart
benbart marked this pull request as ready for review June 13, 2026 00:43
Cameronsplaze
Cameronsplaze requested changes Jun 15, 2026
View reviewed changes

@CameronsplazeCameronsplaze left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love where this is going, nice work!

Comment threadctorm/ctorm/config.py Outdated
Comment threadctorm/ctorm/__main__.py
Comment threadctorm/ctorm/prepare.py Outdated
Comment threadctorm/ctorm/prepare.py Outdated
Comment threadctorm/ctorm/prepare.py
Comment threadctorm/ctorm/prepare.py
@benbart@Cameronsplaze
PR-7456 replace aws client member vars with cached functions, review …
c835c4c
…suggestion
Co-Authored-By: Cameron Showalter <cjshowalter@alaska.edu>
@benbart
benbart requested a review from reweedenJune 18, 2026 18:13
Cameronsplaze
Cameronsplaze approved these changes Jun 18, 2026
View reviewed changes

@CameronsplazeCameronsplaze left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this wasn't going into main before. Here's the changes I'd suggest, but none of them are blockers

Comment threadctorm/ctorm/config.py Outdated
Comment threadctorm/ctorm/prepare.py Outdated
@benbart@Cameronsplaze
PR-7501 review suggestions
f5c1bca
Co-Authored-By: Cameron Showalter <cjshowalter@alaska.edu>
@benbart
benbart merged commit a42c99d into CTORMJun 18, 2026
5 of 6 checks passed
@benbart
benbart deleted the bbarton/PR-7456 branch June 18, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjclarkgjclarkgjclark left review comments
@CameronsplazeCameronsplazeCameronsplaze approved these changes
@mckadesorensenmckadesorensenAwaiting requested review from mckadesorensen
@reweedenreweedenAwaiting requested review from reweeden

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbart@Cameronsplaze@gjclark