Avoid __popcnt64 on MSVC Windows 32-bit platform - #87
Open
frederick-vs-ja wants to merge 1 commit into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
frederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
September 12, 2024 03:38
3d0c4a6 to
5eea86fComparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
September 19, 2024 07:34
5eea86f to
87ded4fComparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
2 times, most recently
from
October 15, 2024 05:35
6b8e567 to
ebb6e97Compare
This comment was marked as outdated.
This comment was marked as outdated.
frederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
November 20, 2024 01:26
ebb6e97 to
c1f5d03Comparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
November 27, 2024 10:28
c1f5d03 to
0e11ec7Comparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
2 times, most recently
from
January 23, 2025 03:10
74e58fc to
48dbdb4Comparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
January 26, 2025 03:05
48dbdb4 to
4a720aaCompare
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
frederick-vs-ja
commented
Oct 6, 2025
Author
Gently ping @asg017 |
vlasky added a commit
to vlasky/sqlite-vec
that referenced
this pull request
Dec 2, 2025
__popcnt64 intrinsic is not available on 32-bit Windows. Split u64 into two u32 values and use __popcnt on each half.
frederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
February 25, 2026 08:57
4a720aa to
9dbf751Comparefrederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
2 times, most recently
from
March 31, 2026 10:20
39e06f7 to
2c35119CompareThe `__popcnt64` intrinsic isn't supported on 32-bit Windows, so `__popcnt` should be used instead.
frederick-vs-jaforce-pushed
the
msvc-win32-popcnt
branch
from
July 14, 2026 02:26
2c35119 to
cce2bcbCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__popcnt64intrinsic isn't supported on 32-bit Windows, so__popcntshould be used instead.See also https://learn.microsoft.com/en-us/cpp/intrinsics/popcnt16-popcnt-popcnt64?view=msvc-170.
IMO, ideally we should use
stdc_count_ones(see here and WG14 N3220). But it will take a long long while until C23 will become popular enough.