Skip to content

Bug fix on logging - #57

Open
Maggi-Andrea wants to merge 1 commit into
ask:masterfrom
Maggi-Andrea:logging_bug_fix
Open

Bug fix on logging#57
Maggi-Andrea wants to merge 1 commit into
ask:masterfrom
Maggi-Andrea:logging_bug_fix

Conversation

@Maggi-Andrea

@Maggi-AndreaMaggi-Andrea commented Jan 22, 2020

Copy link
Copy Markdown

Description

The redirect_stdouts contextmanager need to save the previous stdout and stderr before redirecting to be able to restore the situation as it has found before.

@codecov-io

codecov-io commented Jan 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #57 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #57 +/- ##
==========================================
+ Coverage 96.99% 96.99% +<.01% 
==========================================
Files 27 27 Lines 3824 3826 +2 Branches 417 417 ==========================================
+ Hits 3709 3711 +2 
Misses 102 102 Partials 13 13
Impacted FilesCoverage Δ
mode/utils/logging.py91.7% <100%> (+0.03%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9725a34...33df4b3. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Maggi-Andrea@codecov-io