Uh oh!
There was an error while loading. Please reload this page.
fix: read correct session cookie for auth-aware nav - #16
Merged
Conversation
The auth-detection script was looking for an `assembly_session` cookie that nothing set. The dashboard actually writes `current-portal-session` on the `.assembly.com` parent domain — now that the marketing site serves from assembly.com the cookie is visible, so reading the right name makes the "Open Assembly" / "Log in + Get started" toggle work.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryUpdates the auth-aware presentation bridge to detect the session cookie currently set by the Assembly dashboard.
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness or security issues identified. The change is narrowly scoped to the cookie-name contract used by the existing auth-aware presentation logic, and the affected consumers continue to receive the same boolean auth-state signal. Important Files Changed
Reviews (1): Last reviewed commit: "fix: read the correct session cookie for..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changes the
SESSION_COOKIEconstant insrc/lib/auth-script.tsfrom"assembly_session"(a placeholder) to"current-portal-session"(the cookie the dashboard actually sets).Why
Now that the marketing site serves from
assembly.com, thecurrent-portal-sessioncookie set by the dashboard on.assembly.comis visible to the marketing site. The auth-aware UI (showing "Open Assembly" for signed-in users vs "Log in" + "Get started" for signed-out) was already fully built but never activated because the script was looking for a cookie name that nothing sets.This also affects:
AuthLinkcomponents swap between "Get started" and "Open Assembly" / "Add app to workspace"Screenshots
No visual changes to the components themselves — the
auth-only/unauth-onlyCSS mechanism and nav markup are unchanged. The fix just makes the detection read the right cookie so the existing toggle actually fires.To test on a preview URL (not on
.assembly.com), append?authed=1to simulate signed-in or?authed=0for signed-out.Checklist
npm run buildpassesGenerated by Claude Code