Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Reduce needless recompiles - #40
Merged
Merged
Conversation
Build script calls skeptic which emits information asking cargo to monitor content of README.md.skt.md for changes. If changes to that file are detected cargo should rebuild this crate. In case of this project the files does not exist. This causes cargo to trigger a rebuild every time in hope that it will get created by the build script. The workaround is to create the file that skeptic asks to monitor which stops cargo from triggering the rebuild. For details consult this issues: * budziq/rust-skeptic#25 * rust-lang/cargo#4213
epage
commented
Sep 24, 2017
CollaboratorAuthor
bors: +r |
Contributor
Did you mean "r+"? |
epage
commented
Sep 24, 2017
CollaboratorAuthor
bors: r+ |
borsBot
added a commit
that referenced
this pull request
Sep 24, 2017
40: Reduce needless recompiles r=epage a=epage Build script calls skeptic which emits information asking cargo to monitor content of README.md.skt.md for changes. If changes to that file are detected cargo should rebuild this crate. In case of this project the files does not exist. This causes cargo to trigger a rebuild every time in hope that it will get created by the build script. The workaround is to create the file that skeptic asks to monitor which stops cargo from triggering the rebuild. For details consult this issues: * budziq/rust-skeptic#25 * rust-lang/cargo#4213
Contributor
Build succeeded |
killercup
commented
Sep 25, 2017
Collaborator
Let me highjack this merged PR to thank you for releasing 0.5 and 0.5.1! <3 |
epage
commented
Sep 25, 2017
CollaboratorAuthor
You're welcome! I'm curious, what do you see needing done before moving this to 1.0? While I should get back to my regularly schedule project, I would like to also help work towards more crates hitting 1.0. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build script calls skeptic which emits information asking cargo to
monitor content of README.md.skt.md for changes. If changes to that file
are detected cargo should rebuild this crate. In case of this project
the files does not exist. This causes cargo to trigger a rebuild every
time in hope that it will get created by the build script.
The workaround is to create the file that skeptic asks to monitor which
stops cargo from triggering the rebuild.
For details consult this issues: