Skip to content
This repository was archived by the owner on Dec 29, 2021. It is now read-only.

Add Assert::ignore_status() for ignoring the command status - #56

Merged
epage merged 2 commits into
assert-rs:masterfrom
dsprenkels:ignore_status
Oct 17, 2017
Merged

Add Assert::ignore_status() for ignoring the command status#56
epage merged 2 commits into
assert-rs:masterfrom
dsprenkels:ignore_status

Conversation

@dsprenkels

@dsprenkelsdsprenkels commented Oct 17, 2017•
edited
Loading

Copy link
Copy Markdown

Implements Assert::ignore_status(), which can be used to ignore whether a command exited successfully.

Fixes#23.

@dsprenkelsdsprenkels changed the title Add Assert::ignore_status for ignoring the command statusAdd Assert::ignore_status() for ignoring the command statusOct 17, 2017
@killercup
killercup requested a review from epageOctober 17, 2017 11:19
@killercup

killercup commented Oct 17, 2017

Copy link
Copy Markdown
Collaborator

Thanks! Don't worry about the CI error, it's a known issue (see #50 (comment)).

r? @epage

Do we want the docs to mention that this will reset previously set assertions?

@epage

epage commented Oct 17, 2017

Copy link
Copy Markdown
Collaborator

Do we want the docs to mention that this will reset previously set assertions?

Might be nice because this doesn't just turn off the implicit succeeds() but also turns off the explicit .fails_with(code).

@dsprenkels

dsprenkels commented Oct 17, 2017

Copy link
Copy Markdown
Author

I updated the PR with the new docstring.

Daan Sprenkels added 2 commits October 17, 2017 17:35
Daan Sprenkels
Implement Assert::ignore_status
4de8e96
Fixes#23
Daan Sprenkels
Add note to ignore_status about existing asserts
95be0f1
Namely, it removes any assertions that were previously made.
@epage

epage commented Oct 17, 2017

Copy link
Copy Markdown
Collaborator

bors: r+

borsBot added a commit that referenced this pull request Oct 17, 2017
@bors
Merge#56
7a7fbb5
56: Add Assert::ignore_status() for ignoring the command status r=epage a=dsprenkels
Implements `Assert::ignore_status()`, which can be used to ignore whether a command exited successfully.
Fixes#23.
@bors

borsBot commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

Build failed

@epage

epage commented Oct 17, 2017

Copy link
Copy Markdown
Collaborator

Oh, right. Since nothing is lost with merging it anyways, I guess I'll do it manually.

@epage
epage merged commit a01f933 into assert-rs:masterOct 17, 2017
@dsprenkels
dsprenkels deleted the ignore_status branch October 17, 2017 22:27
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@epageepageAwaiting requested review from epage

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsprenkels@killercup@epage