Skip to content

Apply Rector fixes, resolve PHPStan errors - #70

Merged
sylfabre merged 3 commits into
mainfrom
fix/phpstan-rector
Feb 14, 2026
Merged

Apply Rector fixes, resolve PHPStan errors#70
sylfabre merged 3 commits into
mainfrom
fix/phpstan-rector

Conversation

@sylfabre

Copy link
Copy Markdown
Contributor

Summary

  • Made 52 data provider methods static (Rector)
  • Fixed PHPStan errors: @return list<string> annotations, identity comparison on mixed, type assertion for Constraint array
  • All fixes are zero-risk refactors

Test plan

  • Rector clean
  • PHPStan 0 errors
  • PHPUnit passes (230 tests, 354 assertions, 4 skipped)

🤖 Generated with Claude Code

sylfabre and others added 3 commits February 13, 2026 17:22
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ation overrides

- Type $expected as object[] instead of mixed[] and add is_object() guard
- Remove @return annotations that duplicate Symfony parent definitions
- Regenerate PHPStan baseline

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- EntityValidator: add generic types to ReflectionClass/ReflectionAttribute
- EntityValidator: use ternary to avoid variable type overwrite for BackedEnum
- EntityValidator: pass constraints array directly to All constructor
- EntityValidatorTest: match All constructor fix
- IntegerProvider: add native int|float return types

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
50.0% Coverage on New Code (required ≥ 80%)
20 Added Technical Debt (required ≤ 0)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sylfabre
sylfabre merged commit 5462444 into main Feb 14, 2026
3 of 6 checks passed
@sylfabre
sylfabre deleted the fix/phpstan-rector branch February 14, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant