Support (most of) the elementwise functions in the Array API - #22
Open
mhvk wants to merge 2 commits into
Open
Conversation
Do this via __array_ufunc__, using astropy machinery. A few functions are not yet supported as they are not ufuncs. Relative to astropy Quantity, the main change is to change the output machinery to take into account that our Quantity is immutable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds supports for ufuncs, and therewith for most of the element-wise functions. Also tests that for array types that support them, we can deal with passing in explicit outputs and with ufunc methods (reduce, reduce_at, at, accumulate).
p.s. This PR is perhaps better not squash-merged.