Skip to content

revert misuse of programmatical approach in setup.py - #1303

Merged
gonchik merged 1 commit into
atlassian-api:masterfrom
FCamborda:master
Jan 17, 2024
Merged

revert misuse of programmatical approach in setup.py#1303
gonchik merged 1 commit into
atlassian-api:masterfrom
FCamborda:master

Conversation

@FCamborda

Copy link
Copy Markdown
Contributor

setup.py was ditched a long time ago and newer PEPs recommend using setup.cfg or pyproject.toml

The last changes in setup.py created a misdirected dependency between requirements.txt and setup.py, which included an optional dependency that is causing problems upstreams.

This PR merely reverts those changes in favour for the old already-working setup.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1045f57) 34.49% compared to head (21993fd) 34.49%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## master #1303 +/- ##
=======================================
Coverage 34.49% 34.49% =======================================
Files 45 45 Lines 8257 8257 Branches 1146 1146 =======================================
Hits 2848 2848 Misses 5295 5295 Partials 114 114 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik
gonchik merged commit 9c6f517 into atlassian-api:masterJan 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@FCamborda@codecov-commenter@gonchik