Skip to content

Upload Bootstrapped Repository - #10

Open
aminya wants to merge 9 commits into
masterfrom
bootstrap_upload
Open

Upload Bootstrapped Repository#10
aminya wants to merge 9 commits into
masterfrom
bootstrap_upload

Conversation

@aminya

@aminyaaminya commented Jul 4, 2020

Copy link
Copy Markdown
Member

Description of the change

This adds a step to the release CI that uploads the ready bootstrapped repository. This provides a ready development environment for people to start hacking Atom's Core without running and dealing with the bootstrap script (similar to a pre-built docker images).

Verification

The CI passes

@DeeDeeG

This comment has been minimized.

@aminya

Copy link
Copy Markdown
MemberAuthor

This gets uploaded to Azure artifacts. How do we upload it to the release page of GitHub?

@DeeDeeG

DeeDeeG commented Jul 5, 2020

Copy link
Copy Markdown
Member

With the GitHub API I think.

Making a correct HTTP POST to the API some way or other.

https://docs.github.com/en/rest/reference/repos#upload-a-release-asset

Edit:

@aminya

Copy link
Copy Markdown
MemberAuthor

It seems we already have the scripts needed for releasing. We just need to test and try it to see if we need to add some variables or tokens.

@aminyaaminya mentioned this pull request Jul 6, 2020
@aminya

aminya commented Jul 6, 2020

Copy link
Copy Markdown
MemberAuthor

We can probably reuse the bootstrapped repository in other jobs. Now MacOS bootstraps atom 4 times in total! (each being ~10min). We can reduce this time by uploading and downloading it.

One reason for Windows tests failing is that all the tests run at once in one machine which stops responding properly. If we reuse the bootstrapped repo, we can speed up the CI.

There is probably a better way. We might just cache the repository for the next job. This is easy in GitHub actions and should be possible in Azure too.
Edit: yes there exists!
https://docs.microsoft.com/en-us/azure/devops/pipelines/release/caching?view=azure-devops
https://devblogs.microsoft.com/devops/caching-and-faster-artifacts-in-azure-pipelines/

@DeeDeeG

This comment has been minimized.

@aminya

This comment has been minimized.

@aminya
aminyaforce-pushed the master branch 3 times, most recently from 0247565 to adaefd5CompareJuly 8, 2020 15:33
@aminyaaminya changed the title Upload Bootstraped Repository Upload Bootstrapped RepositoryJul 9, 2020
@aminya
aminya marked this pull request as draft July 9, 2020 07:59
@aminyaaminya added the CI label Jul 9, 2020
@aminyaaminya linked an issue Jul 9, 2020 that may be closed by this pull request
@DeeDeeG

This comment has been minimized.

@DeeDeeGDeeDeeG closed this Jul 10, 2020
@aminyaaminya reopened this Jul 10, 2020
@aminya

Copy link
Copy Markdown
MemberAuthor

I want to merge this eventually (only on release builds). We can release bootstrapped repositories with our binaries.

@aminyaaminya self-assigned this Jul 16, 2020
@aminya
aminyaforce-pushed the master branch 3 times, most recently from 0f34404 to 52de343CompareJuly 16, 2020 13:31
@DeeDeeG

This comment has been minimized.

@aminya
aminyaforce-pushed the bootstrap_upload branch 3 times, most recently from 35c3926 to b24b99aCompareAugust 28, 2020 08:28
@aminya
aminyaforce-pushed the master branch 3 times, most recently from 87c664d to 67dcaefCompareSeptember 18, 2020 12:24
@aminya
aminyaforce-pushed the master branch 3 times, most recently from d5b2b31 to 1808785CompareOctober 2, 2020 00:10
@aminya
aminya marked this pull request as ready for review December 30, 2020 21:49
@aminyaaminya closed this Jul 22, 2021
@aminyaaminya closed this Jul 22, 2021
@aminyaaminya reopened this Jul 22, 2021
@iamunadike

Copy link
Copy Markdown

As you can see most checks did not pass

aminya added 9 commits July 7, 2022 19:08
to provide a ready development environment (similar to a pre-built
docker image)
Only uploaded the release job
Benchmarks:
total size: 1.74 GB
method/time/final_size
ultra 2:19 494MB
maximum 1:52 511MB
normal 1:12 528MB
fast 0:40 604MB
fastest 0:32 658MB
This shows if we are running the build job or the test job
@aminya
aminyaforce-pushed the bootstrap_upload branch from a6e631c to 9b4f97dCompareJuly 8, 2022 02:08

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest finding anything wrong because tests are not passing.

@aminyaaminya removed their assignment Dec 13, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting up Azure pipelines

3 participants

@aminya@DeeDeeG@iamunadike