Uh oh!
There was an error while loading. Please reload this page.
Parallel transpiling (build) - #195
Merged
Merged
Conversation
It is not used in script-runner
Print the output finally to ease diagnosing
This reverts commit 8f1a2c4.
aminya
commented
Sep 30, 2020
MemberAuthor
Upstream: atom#21401 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR parallelizes the transpiling part of the build, so they run on different threads. This is built on top of atom#21308 and uses threads as its script-runner. The changes to the scripts/lib are very minimal. The build script is changed to support running the threads.
Note: This PR is part of the series that speed up the build/bootstrap of Atom atom#21308atom#21342atom#21398 and more PRs that are coming (such as parallelizing copy assets, clean, etc). See #155.
Verification
The local builds/CI pass all the tests,
Benefits
Results in a faster building of Atom locally or in the CI.
Release Notes
Faster building by using threads for transpiling.