Uh oh!
There was an error while loading. Please reload this page.
decaffinate and format - #315
Closed
jeff-hykin wants to merge 14 commits into
Closed
Conversation
aminya
commented
Aug 29, 2021
Member
Please use decaffeinate instead of coffeescript itself |
jeff-hykin
commented
Sep 10, 2021
Author
Well I was trying to first compile it the same way it was compiled for runtime so that correctness would be ensured. Then I was gradually going to get it closer to being human readable like decaffeinate does. However it looks like even this first attempt failed to build :/ so I'll have to go back and try not formatting them at all this time. |
aminya
commented
Sep 10, 2021
Member
That's because you used CoffeeScript 2, which has some breaking changes compared to v1. |
jeff-hykin
commented
Sep 11, 2021
Author
Oh, I didn't realize Atom used v1. Thanks, that would've taken me forever to figure out |
This reverts commit 0d50bde.
subrepo: subdir: "acpm" merged: "bbedc64fc" upstream: origin: "https://github.com/jeff-hykin/acpm" branch: "master" commit: "bbedc64fc" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
subrepo: subdir: "acpm" merged: "2eaa38f15" upstream: origin: "https://github.com/jeff-hykin/acpm" branch: "master" commit: "2eaa38f15" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
subrepo: subdir: "acpm" merged: "eb2e10fd4" upstream: origin: "https://github.com/jeff-hykin/acpm" branch: "master" commit: "eb2e10fd4" git-subrepo: version: "0.4.3" origin: "???" commit: "???"
aminya
requested changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just wanted to make a PR to run the tests