Uh oh!
There was an error while loading. Please reload this page.
➡️ Migrate all language packages + Bump Tree Sitter - #416
Conversation
mauricioszabo
commented
Jul 3, 2022
Can you give an example? I'm using these modifications for a whole week now, and did not find any issues (well, I am using the version that I bumped Electron too, but I'm not sure if this could change things this much) |
See the failing tests. HTML, Java, and Ruby have changed. Tree-sitter is the grammar of Atom, and changing it is actually a big deal. |
aminya
commented
Jul 3, 2022
Cherry-picked #417. We should fix the failing tests (there are a lot) before we can merge this. |
To make #386 reviewable, that pr will be separated into many simpler prs. This is one of them. This first commit does the following: - update package.json - update package-lock.json using `./script/build` which also seems to update `apm/package-lock.json` - update packages/README.md - clone all language packages. Specifically: - `mkdir packages/language-<all of them>` - `cd packages/about` - For all languages: - `cd ../language-<>` - `git clone language-<>` - Move all files except `.git` from `language-<>/language-<>` to `language-<>` - delete `language-<>/language-<>` Since at first I accidentally updated `dependencies` then `packageDependencies`, it appears that since the versions of language-c, language-css, language-go, language-javascript, and language-sass don't match, `dependencies` was reset for those versions. [Those repos just happen to be precisely the ones that have tree-sitter v19](https://github.com/icecream17/atom-update-backlog/blob/main/Languages.md), (sans language-sass), which [currently breaks atom](atom#22129). So even though their repos are now in `packages`, **I've decided to not use them**. This is done by updating `packageDependencies` only for non-breaking languages.
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
left a comment
There was a problem hiding this comment.
We should update node-abi in all the packages
By the way, tree-sitter/tree-sitter-typescript#146 (comment) |
| "url": "https://github.com/atom/language-typescript/issues" | ||
| }, | ||
| "dependencies": { | ||
| "tree-sitter-typescript": "0.20.1" |
There was a problem hiding this comment.
| "tree-sitter-typescript": "0.20.1" | |
| "tree-sitter-typescript": "github:tree-sitter/tree-sitter-typescript#master" |
ghost
commented
Jul 18, 2022
It references "vscode" in the github repository name. Those are not for Atom. |
aminya
commented
Jul 18, 2022
Tree-sitter is editor agnostic. |
@aminya I made this fork specifically for Atom Community https://github.com/stechness/atomcommunity-parse-tree. |
Continuation of #403 and #399. Please read the descriptions of those PRs first.