Skip to content

collect console log in renderer tests - #63

Merged
aminya merged 2 commits into
masterfrom
renderer_test_collect_output
Jul 25, 2020
Merged

collect console log in renderer tests#63
aminya merged 2 commits into
masterfrom
renderer_test_collect_output

Conversation

@aminya

Copy link
Copy Markdown
Member

This is a patch for #50 that collects the console log and prints it at the end.

@aminya

aminya commented Jul 25, 2020

Copy link
Copy Markdown
MemberAuthor

@DeeDeeG turns out using async.parallel does not work well with Atom. Switching to async.series, now most of the tests pass without any issues.

We can try async.parallelLimit with which limits the number of processes that run in parallel. Setting the number to 2 may be enough for letting another process to run in case of a timeout.

aminya added 2 commits July 24, 2020 21:03
Print the output finally to ease diagnosing
@aminya
aminyaforce-pushed the renderer_test_collect_output branch from d0519af to 3bdd637CompareJuly 25, 2020 02:04
@aminya
aminya merged commit 6450e5c into masterJul 25, 2020
@aminyaaminya mentioned this pull request Jul 25, 2020
@aminyaaminya linked an issue Jul 25, 2020 that may be closed by this pull request
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting up Azure pipelines

1 participant

@aminya