Skip to content

Test: wrap test creation in functions - #96

Merged
aminya merged 2 commits into
masterfrom
test-performance
Aug 21, 2020
Merged

Test: wrap test creation in functions#96
aminya merged 2 commits into
masterfrom
test-performance

Conversation

@aminya

@aminyaaminya commented Aug 21, 2020

Copy link
Copy Markdown
Member

Test: create the renderer and package test only if needed. This speeds up test env preparation.

Verification

Just wraps the code in functions.

Continuation of #50

@aminyaaminya changed the title Test: create the renderer and package test only if neededTest: wrap test creation in functionsAug 21, 2020
@DeeDeeG

DeeDeeG commented Aug 21, 2020

Copy link
Copy Markdown
Member

This seems good to me. 👍

Technical note: Not just GitHub, but Git itself will think this has a huge diff. So sadly this small change can expose us to merge conflicts. It is what it is, no real way around it, other than hopefully upstreaming this eventually. Edit to add: Everything we do can expose us to merge conflicts. It's no big deal; if we understand how the code works, merge conflicts are easy to solve.

@aminya
aminya merged commit 24504c8 into masterAug 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@aminya@DeeDeeG