Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Refactoring packages #1126

Description

@kevinsawicki

List of things that should be done to clean up each package

Remove use of window globals and use them from atom global instead

  • window.syntax ➡️ atom.syntax
  • window.config ➡️ atom.config
  • window.pasteboard ➡️ atom.pasteboard
  • window.keymap ➡️ atom.keymap
  • window.project ➡️ atom.project
  • window.rootView ➡️ atom.rootView

Remove use of package manager methods on atom, use them via atom.packages instead

  • atom.activatePackage ➡️ atom.packages.activatePackage

Remove use of deserializer helpers on window

  • registerDeserializer ➡️ atom.deserializers.add

Remove use of emissary Emitter shims

  • one ➡️ once
  • trigger ➡️ emit
  • subscriptionCount ➡️ getSubscriptionCount

Remove use of the following fs methods

  • exists ➡️ existsSync
  • makeTree ➡️ makeTreeSync
  • move ➡️ moveSync
  • read ➡️ readFileSync
  • remove ➡️ removeSync
  • write ➡️ writeFile
  • writeSync ➡️ writeFileSync

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions