Uh oh!
There was an error while loading. Please reload this page.
Ensure submodule inclusion + Fix the tests - #104
Conversation
aminya
commented
Dec 30, 2020
@sadick254@darangi This bug prevents people to be able to bootstrap Atom. Could you merge it as soon as possible? It should be released as 5.7.1 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
It is fixed in this commit. I would recommend closing the PR to speed up the process. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fbd28b1 to
4f2bdc8Compare@sadick254 The issue that this PR fixes is much important than what I see has been merged yesterday. Could you merge this? Atom cannot be bootstrapped because of this. FYI, 1 person has left our atom-community organization since two weeks ago. 😞 |
DeeDeeG
commented
Jan 12, 2021
@sadick254 I posted an issue #109 to fully explain the issue, but basically This PR (or a similar approach) would make it so the submodule initializes automatically during the |
@aminya if we merge atom-community/apm#70 and update our copy of Eventually having a new version of |
DeeDeeG
commented
Jan 14, 2021
Thank you for merging, and for publishing the new release! |
Description of the change
Since #103 is not still merged:
Benefits
Fixes the Atom bootstrap error:
Details
Fixes#69
Closes#105
Verification
The CI and the tests pass:

After publishing
Atom and apm should bump their dependency to 5.7.1.