Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

GitHub tab crashes upon lost of internet connection #1844

Description

@vanessayuenn

Description

GitHub tab does not handle internet connection dropping well.

Steps to Reproduce

  1. Open a project in Atom that has a GitHub repo with opened PRs
  2. Open GitHub tab
  3. Click on any PR from the list
  4. Opens Network tab in Chrome devtool and check the "Offline" box (or just disconnect from internet in any way)
  5. Click on another PR from GitHub tab
  6. Watch the world crash and burn

image

Expected behavior:

Gracefully fail to fetch any additional info from github.com, and display a nice message informing users they have lost internet connection.

Actual behavior:

The whole package crashes with no way to recover beside a full reload.

Reproduces how often:

100%

Versions

All versions

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugpapercutSmall-scope issues and bugs we can use to backfill our sprint plans

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions