Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Changed files tabs show inaccurate file paths #1853

Description

@vanessayuenn

Description

It is a git diff default behaviour to use a/ to prefix source file and b/ to prefix destination file (see the docs for more detail). Within the codebase of the pacakge, we work around this by using --no-prefix flag to get diffs, but changed files tab instead get the diff from GitHub API, which doesn't have a no-prefix option. As a result, some file paths in PR changed files have their prefixes included as well.

Steps to Reproduce

  1. Open "Files" tab in PR view
  2. Observe that some file paths have b/ in front of it.

Expected behavior:

File patch title shows the accurate file path.

Actual behavior:

Some file paths show up with b/ in front of it.

Reproduces how often:

100%

Additional Information

image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions