Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Stack trace on opening GitHub tab #1921

Description

@smashwilson

Prerequisites

Description

When attempting to open the GitHub tab on atom/find-and-replace, I'm seeing a stacktrace in the dev console.

Steps to Reproduce

  1. Clone atom/find-and-replace and open it in Atom.
  2. Click the GitHub status bar tile to open the GitHub tab.

Expected behavior:

The GitHub tab should open and a list of open pull requests should appear.

Actual behavior:

The following stacktrace appears in the dev console:

/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:179 TypeError: Cannot read property 'login' of null
    at new Issueish (issueish.js? [sm]:2)
    at issueishes.props.results.map.node (issueish-list-controller.js? [sm]:15)
    at Array.map (<anonymous>)
    at getDerivedStateFromProps (issueish-list-controller.js? [sm]:15)
    at Qf (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:133)
    at $f (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:138)
    at wg (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:157)
    at Ag (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:169)
    at lh (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:204)
    at mh (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:205)
    at Ph (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:220)
    at Qh (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:219)
    at sh (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:216)
    at Uf (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:214)
    at Object.enqueueSetState (/Users/smashwilson/.atom/packages/github/node_modules/react-dom/cjs/react-dom.production.min.js:134)
    at ReactRelayQueryRenderer.G.setState (/Users/smashwilson/.atom/packages/github/node_modules/react/cjs/react.production.min.js:13)
    at retryCallbacks.handleDataChange (/Users/smashwilson/.atom/packages/github/node_modules/react-relay/lib/ReactRelayQueryRenderer.js:149)
    at /Users/smashwilson/.atom/packages/github/node_modules/react-relay/lib/ReactRelayQueryFetcher.js:291
    at Array.forEach (<anonymous>)
    at ReactRelayQueryFetcher._onQueryDataAvailable (/Users/smashwilson/.atom/packages/github/node_modules/react-relay/lib/ReactRelayQueryFetcher.js:290)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/react-relay/lib/ReactRelayQueryFetcher.js:157)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:560)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:560)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:226)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:560)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:560)
    at /Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:491
    at _subscribe (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:608)
    at RelayObservable.subscribe (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:314)
    at Object.next (/Users/smashwilson/.atom/packages/github/node_modules/relay-runtime/lib/RelayObservable.js:375)

Reproduces how often:

100%

Versions

github@0.24.0 (atom/github#b5091255)

Additional Information

I'm guessing that we're assuming login is a required property in the GraphQL schema when it is not. I suspect the problem is this PR opened by a now-deleted user account:

screen shot 2019-01-25 at 9 57 43 am

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions