Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Comment positioning bug in PRs with diff-gated patches #2008

Description

@vanessayuenn

Steps to reproduce:

  1. Make a PR with a large diff and a small diff (make sure the large one will be positioned above the small one)
  2. Comment on the smaller diff
  3. Open PR in atom
  4. Observe that the comment is in the right spot
  5. Expand the diff gated patch
  6. Observe that the comment is now misplaced

kapture 2019-03-07 at 13 31 53
Reproduced with this PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions